Hey Nick,

Thanks for your feedback.

        From n...@holland-consulting.net Thu Jun  4 23:58:12 2009

        when you see developers doing KNF commits, they aren't doing
        it as the end goal, [...]

        Changing the whitespace in the source code doesn't improve
        OpenBSD.  Reading the code is what makes the improvement.
        If all you are doing is a mechanical KNFing, please don't.
        If you aren't finding OTHER errors while reading code, just
        keep reading, not changing.

Thanks, and yes, this is advice that I have seen before. Actually, 
I don't want to do a mechanical KNFing, but I intend to do some work 
on nvi(1) and I want to familiarize myself with the code and afterwards 
make some changes to it. [That is, if my free time lasts.] 

As a part of this, I figured that I'd go ahead and KNF things while 
I was learning the code, and then add in my changes. I'm not so filled 
with free time that I would just go around KNFing things for the fun 
of it. ;-)

If this isn't the way to go, please, do let me know.

-- 
Aaron W. Hsu <arcf...@sacrideo.us> | <http://www.sacrideo.us>
"Government is the great fiction, through which everybody endeavors to
live at the expense of everybody else." -- Frederic Bastiat
+++++++++++++++ ((lambda (x) (x x)) (lambda (x) (x x))) ++++++++++++++

Reply via email to