On 10/4/10, David Gwynne <l...@animata.net> wrote: ... > this restores the visibility of network livelocks to systat. > > anyone object? if not i'll commit it tomorrow morning around 10am > in a GMT+10 timezeon.
I like it, with one micro suggestion: ... > --- sbin/sysctl/sysctl.c 19 Aug 2010 18:14:14 -0000 1.173 > +++ sbin/sysctl/sysctl.c 5 Oct 2010 01:20:59 -0000 > @@ -447,6 +447,9 @@ parse(char *string, int flags) > case KERN_CONSDEV: > special |= CHRDEV; > break; > + case KERN_NETLIVELOCKS: > + special |= UNSIGNED; > + break; > } > break; > The KERN_NETLIVELOCKS case could be joined with the KERN_HOSTID and KERN_ARND cases earlier in the file. That switch() isn't in pure numerical order, so there's no need to put this last, separate from the other "special |= UNSIGNED" cases. ok guenther@
