Hi guys,

one of our users complained that he cannot enter the variance of 0.5 to the basic image processing Gaussian filter. And indeed, for Gaussian image filter, the normal spinbox is used as an imput even though itk accepts a double. Similar thing could be said for gradient filter. Is there any specific reason for this? If not, find a simple patch attached.

All best,
   Rostislav.

PS: that file desperately needs some refactoring, but I guess you know it :)
From ca1e1cb25fdf693c89cdfa65b85fd2d1502970dc Mon Sep 17 00:00:00 2001
From: Rostislav Khlebnikov <[email protected]>
Date: Thu, 14 May 2015 19:34:30 +0100
Subject: [PATCH] Double parameters for gaussian and gradient filters.

---
 .../src/internal/QmitkBasicImageProcessingView.cpp | 35 ++++++++++++++--------
 1 file changed, 23 insertions(+), 12 deletions(-)

diff --git 
a/Plugins/org.mitk.gui.qt.basicimageprocessing/src/internal/QmitkBasicImageProcessingView.cpp
 
b/Plugins/org.mitk.gui.qt.basicimageprocessing/src/internal/QmitkBasicImageProcessingView.cpp
index 60d3d93..5096a43 100644
--- 
a/Plugins/org.mitk.gui.qt.basicimageprocessing/src/internal/QmitkBasicImageProcessingView.cpp
+++ 
b/Plugins/org.mitk.gui.qt.basicimageprocessing/src/internal/QmitkBasicImageProcessingView.cpp
@@ -388,6 +388,8 @@ void QmitkBasicImageProcessing::SelectAction(int action)
     m_Controls->dsbParam1->hide();
     m_Controls->dsbParam2->hide();
     m_Controls->dsbParam3->hide();
+    m_Controls->tlParam1->show();
+    m_Controls->tlParam2->show();
     m_Controls->tlParam3->hide();
     m_Controls->tlParam4->hide();
     m_Controls->sbParam1->show();
@@ -401,12 +403,16 @@ void QmitkBasicImageProcessing::SelectAction(int action)
     {
       m_SelectedAction = GAUSSIAN;
       m_Controls->tlParam1->setEnabled(true);
-      m_Controls->sbParam1->setEnabled(true);
+      m_Controls->sbParam1->hide();
+      m_Controls->dsbParam1->show();
+      m_Controls->dsbParam1->setEnabled(true);
       text1 = "&Variance:";
+      m_Controls->tlParam2->hide();
+      m_Controls->sbParam2->hide();
 
-      m_Controls->sbParam1->setMinimum( 0 );
-      m_Controls->sbParam1->setMaximum( 200 );
-      m_Controls->sbParam1->setValue( 2 );
+      m_Controls->dsbParam1->setMinimum( 0 );
+      m_Controls->dsbParam1->setMaximum( 200 );
+      m_Controls->dsbParam1->setValue( 2 );
       break;
     }
 
@@ -492,11 +498,16 @@ void QmitkBasicImageProcessing::SelectAction(int action)
     {
       m_SelectedAction = GRADIENT;
       m_Controls->tlParam1->setEnabled(true);
-      m_Controls->sbParam1->setEnabled(true);
+      m_Controls->sbParam1->hide();
+      m_Controls->dsbParam1->show();
+      m_Controls->dsbParam1->setEnabled(true);
       text1 = "Sigma of Gaussian Kernel:\n(in Image Spacing Units)";
-      m_Controls->sbParam1->setMinimum( 0 );
-      m_Controls->sbParam1->setMaximum( 200 );
-      m_Controls->sbParam1->setValue( 2 );
+      m_Controls->tlParam2->hide();
+      m_Controls->sbParam2->hide();
+
+      m_Controls->dsbParam1->setMinimum( 0 );
+      m_Controls->dsbParam1->setMaximum( 200 );
+      m_Controls->dsbParam1->setValue( 2 );
       break;
     }
 
@@ -705,10 +716,10 @@ void QmitkBasicImageProcessing::StartButtonClicked()
     {
       GaussianFilterType::Pointer gaussianFilter = GaussianFilterType::New();
       gaussianFilter->SetInput( itkImage );
-      gaussianFilter->SetVariance( param1 );
+      gaussianFilter->SetVariance( dparam1 );
       gaussianFilter->UpdateLargestPossibleRegion();
       newImage = mitk::ImportItkImage(gaussianFilter->GetOutput())->Clone();
-      nameAddition << "_Gaussian_var_" << param1;
+      nameAddition << "_Gaussian_var_" << dparam1;
       std::cout << "Gaussian filtering successful." << std::endl;
       break;
     }
@@ -830,10 +841,10 @@ void QmitkBasicImageProcessing::StartButtonClicked()
     {
       GradientFilterType::Pointer gradientFilter = GradientFilterType::New();
       gradientFilter->SetInput( itkImage );
-      gradientFilter->SetSigma( param1 );
+      gradientFilter->SetSigma( dparam1 );
       gradientFilter->UpdateLargestPossibleRegion();
       newImage = mitk::ImportItkImage(gradientFilter->GetOutput())->Clone();
-      nameAddition << "_Gradient_sigma_" << param1;
+      nameAddition << "_Gradient_sigma_" << dparam1;
       std::cout << "Gradient calculation successful." << std::endl;
       break;
     }
-- 
1.8.4.msysgit.0

------------------------------------------------------------------------------
One dashboard for servers and applications across Physical-Virtual-Cloud 
Widest out-of-the-box monitoring support with 50+ applications
Performance metrics, stats and reports that give you Actionable Insights
Deep dive visibility with transaction tracing using APM Insight.
http://ad.doubleclick.net/ddm/clk/290420510;117567292;y
_______________________________________________
mitk-users mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/mitk-users

Reply via email to