Dear Federico,
I just merged your commit into the current MITK master. Thanks again for your
contribution.
Alexander
Von: Federico Milano [mailto:fmil...@gmail.com]
Gesendet: Mittwoch, 25. April 2018 22:34
An: Seitel, Alexander
Cc: mitk-users@lists.sourceforge.net
Betreff: Re: [mitk-users] Serializing custom properties of a NavigationTool
Hello. I have created a PR with the mentioned changes:
https://github.com/MITK/MITK/pull/224
Please let me know if you want to discuss anything.
Thanks,
Federico
On Mon, Apr 23, 2018 at 10:03 AM, Seitel, Alexander
<a.sei...@dkfz-heidelberg.de<mailto:a.sei...@dkfz-heidelberg.de>> wrote:
Hi Federico,
thanks for offering to contribute to MITK. Generally it is a good idea to save
all the properties associated with this DataNode.
As a remark, this DataNode associated with the NavigationTool is intended to be
the representation object (in most cases a surface) of the Navigation tool
which is continuously updated with the current tracking pose. As a
representation object it can be chosen by the user and can also be changed
within the application. Tool specific properties set to this DataNode will be
lost as soon as a new representation object is loaded.
It would be great if you could share your idea on how you would solve the
serialization and deserialization in the case you describe. I don’t see any
obvious problem applying your changes.
Looking forward to receiving your contribution.
Best
Alexander
Von: Federico Milano [mailto:fmil...@gmail.com<mailto:fmil...@gmail.com>]
Gesendet: Sonntag, 22. April 2018 04:45
An: mitk-users@lists.sourceforge.net<mailto:mitk-users@lists.sourceforge.net>
Betreff: [mitk-users] Serializing custom properties of a NavigationTool
Hello. I want to save some custom information in a NavigationTool (stored in a
tool storage). I first thought that since a NavigationTool has an associated
DataNode, that then I could add some custom Properties to that DataNode and
that the NavigationToolSerializer would serialize them for me. Then I found
that it does not work like that. The NavigationToolWriter just looks for
certain Properties and then it saves only those properties. I have modified the
NavigationToolWriter (and the NavigationToolReader) to save/read all the
Properties in the tool DataNode.
I can prepare a PR with this mod, do you think there is a chance that you
accept that PR? Or is there a strong reason for maintaining the actual design?
Thanks,
Federico
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
mitk-users mailing list
mitk-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mitk-users
