Hi again,
I already had a look at the issue and I would argue that, while it is an
implicit API-change, it works as expected and intended. The commit message
contains a rationale. The name is really something that should be the property
of the base data rather than the data node, which is dedicated to
non-persistent and typically visualization related properties. The most
straight-forward solution would be to replace your call of SetName() with
SetStringProperty("name", ...) instead of changing the code of SetName(). By
default, this will add the name property to the data node without falling back
to a potentially existing base data property. Another solution would be to also
listen to the Modified event of the base data or its property list or even
directly of its name StringProperty.
Best,
Stefan
________________________________________
Von: Dinkelacker, Stefan <[email protected]>
Gesendet: Donnerstag, 9. November 2023 20:28
An: Schwoerer, Trudbert
Cc: [email protected]
Betreff: Re: [mitk-users] Issue introduced by commit
a095aba80ec692f287d3c8f2a4ea3609d468c79d
Hi Trudbert,
thank you for the report. We disabled new accounts on our Phabricator instance
indeed due to excessive spam attacks. I'll create a task on your behalf. As we
are currently in the crunch and testing phase for the upcoming release, we
cannot promise to include a fix already, though.
Best,
Stefan
________________________________________
Von: Schwoerer, Trudbert via mitk-users <[email protected]>
Gesendet: Mittwoch, 8. November 2023 11:00
An: [email protected]
Betreff: [Extern] - [mitk-users] Issue introduced by commit
a095aba80ec692f287d3c8f2a4ea3609d468c79d
Hi all.
I tried to create an issue in the MITK issue tracker but failed. I was not able
to create an account for an external user at https://phabricator.mitk.org/.
Therefor I try to make the issue known this way.
The commit at June-09-2022 (a095aba80ec692f287d3c8f2a4ea3609d468c79d, "Reduce
name property duality") modified the method mitk::DataNode:: SetName().
StringProperty::SetValue() is used now to set the name of a data node which
does not raise a "modified" event. This caused a bug in our MITK based
application which relied on a node-modified callback.
For me it was enough to move the line "this->SetStringProperty("name", name);"
to the top of the method. But this introduces an unrequired redundant code
execution. Don't know how to fix this without violating the intention of the
commit.
Best Regards
Trudbert Schwörer
Stryker Leibinger GmbH
Follow this link to read our Privacy
Statement<https://www.stryker.com/content/stryker/gb/en/legal/global-policy-statement.html/>
_______________________________________________
mitk-users mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/mitk-users
_______________________________________________
mitk-users mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/mitk-users
