Good catch Claudio,
I've been asserted on by that one before. :D
Here's my take on the fix, with Josh's suggestion in there... QList ->
0-indexed
if (row < 0 || row >=
m_pView->m_pTrackTableView->m_pTable->m_pTrackPlaylist->size()) return;
-G
On Thu, Nov 20, 2008 at 9:24 PM, Josh Matthews <[EMAIL PROTECTED]>wrote:
> if (row<=0 && row >
> m_pView->m_pTrackTableView->m_pTable->m_pTrackPlaylist->size())
>
> Is that && really correct? It looks more like it should be || to me.
>
> Cheers,
> Josh
>
>
> On Thu, Nov 20, 2008 at 7:40 PM, Claudio Bantaloukas <
> [EMAIL PROTECTED]> wrote:
>
>> I've been rather busy @ work lately so I haven't had the opportunity
>> to check mixxx, but as I was futzing around yesterday I caught this...
>>
>> Program received signal SIGABRT, Aborted.
>> [Switching to Thread 0xb591d900 (LWP 16646)]
>> 0xb8027430 in __kernel_vsyscall ()
>> (gdb) bt
>> #0 0xb8027430 in __kernel_vsyscall ()
>> #1 0xb6be3880 in raise () from /lib/tls/i686/cmov/libc.so.6
>> #2 0xb6be5248 in abort () from /lib/tls/i686/cmov/libc.so.6
>> #3 0x080dac00 in MessageOutput (type=QtFatalMsg,
>> msg=0xbfd2496c "ASSERT failure in QList<T>::at: \"index out of
>> range\", file /usr/share/qt4/include/QtCore/qlist.h, line 387")
>> at src/main.cpp:95
>> #4 0xb7c41735 in qt_message_output () from /usr/lib/libQtCore.so.4
>> #5 0xb7c41872 in qFatal () from /usr/lib/libQtCore.so.4
>> #6 0xb7c418cc in qt_assert_x () from /usr/lib/libQtCore.so.4
>> #7 0x08135fb6 in QList<TrackInfoObject*>::at (this=0x8665aa0, i=-1)
>> at /usr/share/qt4/include/QtCore/qlist.h:387
>> #8 0x08127fd1 in Track::slotLoadSelectedTrackCh1 (this=0x8665a80,
>> v=127) at src/track.cpp:1257
>> #9 0x081ded55 in Track::qt_metacall (this=0x8665a80,
>> _c=QMetaObject::InvokeMetaMethod, _id=27, _a=0xbfd26b60) at
>> src/.obj/moc_track.cc:181
>>
>> Fix:
>>
>> Index: src/track.cpp
>> ===================================================================
>> --- src/track.cpp (revision 2388)
>> +++ src/track.cpp (working copy)
>> @@ -1254,6 +1254,9 @@
>> if (v && m_pView->m_pTrackTableView->m_pTable) {
>> // Fetch the currently selected track
>> index =
>>
>> m_pView->m_pTrackTableView->m_pSearchFilter->mapToSource(m_pView->m_pTrackTableView->currentIndex());
>> + int row = index.row();
>> + if (row<=0 && row >
>> m_pView->m_pTrackTableView->m_pTable->m_pTrackPlaylist->size())
>> + return;
>> pTrack =
>> m_pView->m_pTrackTableView->m_pTable->m_pTrackPlaylist->at(index.row());
>> // If there is one, load it
>> if (pTrack) slotLoadPlayer1(pTrack);
>> --
>> Claudio Bantaloukas http://www.rdfm.org/ammuzzu/
>>
>> -------------------------------------------------------------------------
>> This SF.Net email is sponsored by the Moblin Your Move Developer's
>> challenge
>> Build the coolest Linux based applications with Moblin SDK & win great
>> prizes
>> Grand prize is a trip for two to an Open Source event anywhere in the
>> world
>> http://moblin-contest.org/redirect.php?banner_id=100&url=/
>> _______________________________________________
>> Mixxx-devel mailing list
>> [email protected]
>> https://lists.sourceforge.net/lists/listinfo/mixxx-devel
>>
>
>
> -------------------------------------------------------------------------
> This SF.Net email is sponsored by the Moblin Your Move Developer's
> challenge
> Build the coolest Linux based applications with Moblin SDK & win great
> prizes
> Grand prize is a trip for two to an Open Source event anywhere in the world
> http://moblin-contest.org/redirect.php?banner_id=100&url=/
> _______________________________________________
> Mixxx-devel mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/mixxx-devel
>
>
--
__
--- == __/ t.O ==--
http://stacktrace.org/
-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
Mixxx-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/mixxx-devel
