We are going to commit this...   Obviously, I'm not a cmake expert, so I
don't know which of the two patches we should use as the base..

If it's Claudio's do we need a new cut of the patch (has it changed?)...
If its Helio's it probably hasn't changed (you said you had it for a
while)...   Ideally we want to get the best bits of both.

-G
              __
--- == __/ t.O ==--
http://stacktrace.org/


On Wed, Dec 10, 2008 at 3:13 AM, Helio Chissini de Castro <[email protected]>wrote:

> On Monday 08 December 2008 04:26:07 Garth Dahlstrom wrote:
> > Had Mixxx scripting on, just deleted those WITH_SCRIPTING lines from the
> > CMakeLists.txt file and it seems to be building...  meh, didn't have
> > scripting on... oh well... maybe lua/python is a dep for scripting,
> though
> > I swear I built script=1 on this machine without lua before...
> >
> The right method would be use cmake -DWITH_SCRIPTING=OFF instead of touch
> or
> alter the CMakeLists.txt
>
> Random thoughts:
> * miss my colorgcc...
> The regular method for cmake is colored output. I ddn't touch the final
> patch
> , but is a matter of a definition inside main CMakeList
>
> * all of the output shit (moc*.*, *.cxx) ended up in src when I called
> Wrong, should be going in the build dir, i can fix this when i back
> tomorrow
> to home
>
> "cmake ." from mixxx/ (where that is the checkout root), argh... did I do
> that wrong?
> Did you run cmake command from same dir as checkout ? For safety reasons i
> will add the instructions to forbidden people try run on same checkout dir
> to
> avoid some mistake.
>
> * CAPS heavy languages give me a headache...
> Is not mandatory, is just a common behavior, but this is a matter of
> choice,
> 50% of people like it, other 50% not.
>
> * the whole, cmake doesn't use a programming language doesn't appear to
> true. IMHO, its another custom macro language...
> Of course it is. but is most shell based, with some minor changes like
> identifiend ifs.
>
> * Debug: Mixxx 1.6.5 "(svn r; built on: Dec  8 2008 @ 00:55:25) " is
> starting...
>  ---> svn rev?  build options?  we gotta have this for when people post bug
> reports.
> Would be easy, we just need see if is a svn build or source build  and add
> it
> in the config options.
>
> * Helio's version looks like if it finds a lib, it turns on the switch...
> I'd be curious to know if it identifies the added dep at packaging time.
> It detects every time you run cmake again.
>
>
> We need this in svn commited soon, otherwise would be complex to be
> changing
> through alter the patches
>
> []'s
>
>
>
> --
> Helio Chissini de Castro
> KDE Project
> Brasil and South America Primary Contact
>
>
> ------------------------------------------------------------------------------
> SF.Net email is Sponsored by MIX09, March 18-20, 2009 in Las Vegas, Nevada.
> The future of the web can't happen without you.  Join us at MIX09 to help
> pave the way to the Next Web now. Learn more and register at
>
> http://ad.doubleclick.net/clk;208669438;13503038;i?http://2009.visitmix.com/
> _______________________________________________
> Mixxx-devel mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/mixxx-devel
>
------------------------------------------------------------------------------
SF.Net email is Sponsored by MIX09, March 18-20, 2009 in Las Vegas, Nevada.
The future of the web can't happen without you.  Join us at MIX09 to help
pave the way to the Next Web now. Learn more and register at
http://ad.doubleclick.net/clk;208669438;13503038;i?http://2009.visitmix.com/
_______________________________________________
Mixxx-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/mixxx-devel

Reply via email to