Navaho Gunleg wrote: > 2009/5/7 Ben Wheeler <[email protected] <mailto:[email protected]>> > > Navaho Gunleg <[email protected] > <mailto:[email protected]>> wrote: > > > 2009/4/26 Andreas Pflug <[email protected] > <mailto:[email protected]>> > >> As soon as I play, the cpu usage rises again (mostly in xorg, > caused by > >> wVuMeter updates), which I reduced drastically by using > repaint() instead of > >> update() in WWidget::setValue(). > ... > > That update( ) in stead of repaint( ) does indeed make a noticable > > difference for the problem I had with the cross-fader widget.. > That waveform > > display is soooo useful as a guidance, it's awesome I can have > it back now. > > :) > > Isn't that the opposite of what Andreas did? He changed update() to > repaint(), you're saying you've changed repaint() to update() ?? > > > No, not at all, I'm sorry if I was not clear. His change just gave me > an idea to poke around in a different file alltogether -- I haven't > been in any of the files that his patch touched. > > I have modifed wslidercomposed.cpp that called the repaint( ), to now > do what QT recommends: call update(). It has major performance > increase over here, the slider-animation was always running an > increasing amount of time behind if it was receiving bursts of MIDI > "fader"-data. Everything seems to indicate that was because something > wanted it repaint'ed all the time.. The (quite trivial) patch has been > attached to this message. :-) Well this IS pretty much the opposite of my finding. I guess that update() does optimize away unnecessary calls, which will be a win if only a fraction is really necessary, but has a big overhead on single calls, in which case repaint does the job directly.
Regards, Andreas ------------------------------------------------------------------------------ Crystal Reports - New Free Runtime and 30 Day Trial Check out the new simplified licensing option that enables unlimited royalty-free distribution of the report engine for externally facing server and web deployment. http://p.sf.net/sfu/businessobjects _______________________________________________ Mixxx-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/mixxx-devel
