On Mon, 2010-05-10 at 14:14 -0300, Bruno Buccolo wrote:
> Hi,
>
> Just wanted to report some progress.
> It's working =)
> We can now map controllers a lot faster now.
> There're still a few ui tweaks to make, such as the ones jus posted.
>
> So, when I was updating a mapping:
> Fader A --> Crossfader
> to Fader B --> Crossfader
>
> I had to create a new mapping, and then erase the old one.
> Pretty straight-forward.
>
> But I think I may have bumped into a bug:
>
> void MidiMapping::removeInputMapping(MidiMessage midiMessage)
> {
> m_inputMapping.remove(midiMessage);
> }
If you use a QMultiHash, then you'll have to change removeInputMapping()
so that it takes both a MidiMessage and MixxxControl as parameters,
otherwise we won't know which hash to remove from the table. (There
could be multiple hashes with the same MidiMessage, as you pointed out
below.)
>
> m_inputMapping is a MidiInputMapping object, which actually
> is a QHash<MidiMessage, MixxxControl>
>
> As djs we might want macros, for instance:
> Fader A --> Volume Deck1 Up
> Fader A --> Volume Deck2 Down
>
> QHash does not allow multiple values, QMultiHash does.
> So, when I call that method when updating say Fader A --> Volume Deck1 Up
> Both entries get deleted, because Fader A emits the same MidiMessage.
>
> So, this QHash is stopping us from using macros.
> I'm gonna try to simply change that to QMultiHash, I just wanted
> to know if anyone knows if that's gonna cause an issue?
>
> Thanks!
The removeInputMapping() problem is about the only big issue I can think
of off the top of my head. I haven't looked at the code, but I'd give it
a try and see what breaks. :)
Thanks,
Albert
>
> On Apr 28, 2010, at 7:07 AM, jus wrote:
>
> > Hello,
> > one small thing coming to my mind regarding MIDI Mapping Usability:
> > If you map some controls with the Wizard, currently all entrys shown in the
> > GUI (Midi preferences dialog) are sorted by midi notes.
> >
> > It would be really useful if the table could be sorted by clicking on the
> > table header ( just like the playlist table),
> > so one could sort by channel, note, etc.
> > Also the table should expand if you expand the GUI (Midi preferences
> > dialog). Currently it has max. size fixed.
> >
> > These small changes would make working with the midi dialog more enjoyable,
> > espacialy if you edit entrys afterwards.
> >
> > jus
> > ------------------------------------------------------------------------------
> > _______________________________________________
> > Mixxx-devel mailing list
> > [email protected]
> > https://lists.sourceforge.net/lists/listinfo/mixxx-devel
>
> Bruno Buccolo
>
>
>
>
> ------------------------------------------------------------------------------
>
> _______________________________________________
> Mixxx-devel mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/mixxx-devel
------------------------------------------------------------------------------
_______________________________________________
Mixxx-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/mixxx-devel
