Hey Owen,

I made a bunch of changes to the way the SoundSource classes work
recently for the plugin work. One major change is that there's no
longer a static ParseHeader function, and instead it's a regular
function called parseHeader(). It's called on every track when we're
scanning the library, and it tries to be entirely self-contained (it
opens it's own file handle, closes them, etc.). In other words, the
file doesn't have to be open()'ed before parseHeader() is called.
Additionally, when a track is loaded into a player, we don't call
parseHeader() again since the TrackInfoObject will already have that
data in it from the library.

Anyways, merging the changes from your mmap patch into my
sadness_ssplugin branch where this took place was really messy, and I
just want to make sure I didn't mess anything up. (All this code is in
trunk now.) If you have some spare time, can you please review my code
in SoundSourceMP3 to make sure I didn't mess up your mmap stuff?

Thanks,
Albert

------------------------------------------------------------------------------

_______________________________________________
Mixxx-devel mailing list
Mixxx-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mixxx-devel

Reply via email to