Hi,
I think that cover art unit tests are not working as expected.
This line from coverartcache_test.cpp :
https://github.com/mixxxdj/mixxx/blob/master/src/test/coverartcache_test.cpp#L32
produces this output during test :
CoverArtUtils::loadCover FILE cover does not exist:
"../../..//src/test/id3-test-data/cover-test.jpg"
"/home/travis/build/mixxxdj/mixxx/src/test/id3-test-data/cover-test.mp3"
so loadCover is failing.
The test is actually succeeding, but I can't figure how it can succeed
without a way to load the test data.
Another strange thing for me :
Last line of the test try to compare embedded cover art in mp3 file with
content of the JPEG file.
but embedded cover in MP3 file is a PNG file.
How can this test succeed comparing a JPEG image with a PNG image ?
having the internal QImage format exactly similar after two different
compression algorithms has been applied (PNG vs JPEG) seems nearly
impossible.
What do you think of it ?
regards,
sb
Le 24/05/2015 21:57, Sébastien Blaisot a écrit :
Well well well, It's worst than I thought...
Selecting mixxx\src\test\id3-test-data as library makes Mixxx crash at
startup (1.12 r5451 64 bits under win seven 64 bits SP1).
Using another library directory and trying each file one after one I
found that the file cover-test.opus makes Mixxx crash (simply drop it
un the library and rescan library)
I can reproduce 100% and filed a bug:
https://bugs.launchpad.net/mixxx/+bug/1458380
Using all files in the src/test/id3-test-data (without the opus file
that causes mixxx to crash), I see well covers for all files except
empty.mp3, artist.mp3 and TOAL_PE2.mp3 (I think they aren't supposed
to contain cover, and jpeg folder file is not used).
BUT the MP3 test case (cover-test.mp3) has PNG cover, NOT JPEG !
You should add a test case with a jpeg embedded cover.
regards,
sb
Le 24/05/2015 15:54, Max Linke a écrit :
Sorry I can't make that build available.
I answered in the bug.
https://bugs.launchpad.net/mixxx/+bug/1451832
Can you check if our test-tracks are also effected for you. Thanks.
On 05/23/2015 07:33 PM, Sebastien BLAISOT wrote:
Can you Make your own build available somewhere so I can try ?
Maybe it's a build env bug. Like jpeg library not installed on
build env.
I have put test tracks with embedded jpeg cover art not shown
under windows in the lp bug I filled. (can't find the number right now)
Sébastien Blaisot
-------- Message d'origine --------
De : Max Linke <max_li...@gmx.de>
Date : 23/05/2015 14:40 (GMT+01:00)
À : Daniel Schürmann <dasch...@mixxx.org>,
mixxx-devel@lists.sourceforge.net
Objet : Re: [Mixxx-devel] release progress
On 05/20/2015 12:40 PM, Daniel Schürmann wrote:
Hi
# Mixxx 1.12 beta #
My Mixxx 1.12 beta experience on Linux is very good. I do not see any
issue that
justifies holding back the release any longer.
On the other hand Mixxx 1.12 beta still suffers 11 critical bugs.
All of
them happen on windows only.
My overall test experiences running Mixxx on windows are also bad, do
others on the list share this experience?
I have problems with the cover-art feature using the release builds
that
we distribute. But I haven't been able to debug this because I can't
reproduce it in with my own builds. Do other people have problems with
the covers?
I haven't done much testing otherwise.
For me those issues actually block a release.
Unfortunately there is no notable progress on these critical issues.
We need help! Is there anyone with a Windows build environment on the
list who can reproduce one of the critical bugs?
# New Soundsource API #
The master branch, including the mp3 seek and click issues and
floating
point samples has reached a stable state.
As discussed before it is planed to release a 1.12.1 or whatever
version, including these
important fixes. Since this will be a bugfix release, it should not
contain new features,
or other risky changes.
We have also some pending pull request on Github, which may not fit to
such a 1.12.1 target.
So I think we should branch a 1.12.1 branch right now.
IMHO we can enter 1.12.1 beta stage after merging Uwes "SoundSource
Plugin API: Version 8" branch.
A release can be scheduled ~ two month after 1.12.0 to allow to
include
add-hock fixes.
What do you think?
Kind regards,
Daniel
------------------------------------------------------------------------------
One dashboard for servers and applications across
Physical-Virtual-Cloud
Widest out-of-the-box monitoring support with 50+ applications
Performance metrics, stats and reports that give you Actionable
Insights
Deep dive visibility with transaction tracing using APM Insight.
http://ad.doubleclick.net/ddm/clk/290420510;117567292;y
_______________________________________________
Get Mixxx, the #1 Free MP3 DJ Mixing software Today
http://mixxx.org
Mixxx-devel mailing list
Mixxx-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mixxx-devel
------------------------------------------------------------------------------
One dashboard for servers and applications across
Physical-Virtual-Cloud
Widest out-of-the-box monitoring support with 50+ applications
Performance metrics, stats and reports that give you Actionable
Insights
Deep dive visibility with transaction tracing using APM Insight.
http://ad.doubleclick.net/ddm/clk/290420510;117567292;y
_______________________________________________
Get Mixxx, the #1 Free MP3 DJ Mixing software Today
http://mixxx.org
Mixxx-devel mailing list
Mixxx-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mixxx-devel
------------------------------------------------------------------------------
One dashboard for servers and applications across Physical-Virtual-Cloud
Widest out-of-the-box monitoring support with 50+ applications
Performance metrics, stats and reports that give you Actionable Insights
Deep dive visibility with transaction tracing using APM Insight.
http://ad.doubleclick.net/ddm/clk/290420510;117567292;y
_______________________________________________
Get Mixxx, the #1 Free MP3 DJ Mixing software Today
http://mixxx.org
Mixxx-devel mailing list
Mixxx-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mixxx-devel
