I've created a PR with astyle settings so that everyone can see how the code looks then.
It seems to me astyle has less problems with a variable line-length then clang-format. The conversion of the code base could be done piece by piece. We just decide to use the auto-formatter from some point on and provide a git-hook script for new contributors (so git will apply astyle/clang-format before every commit). best Max On 06/11/2015 09:24 PM, Tuukka Pasanen wrote: > Hello, > With Mixxx I use astyle: > > astyle --style=java --pad-header -s4 --lineend=linux > --max-code-length=80 --break-after-logical --convert-tabs file.cpp > > it seems that they also have Google style and pico style (what ever > that means but I'll start to use it). I prefer 120 because hey it's > 2015. I code in nano but I have wider screen! (and that's a fact) > > Sincerely, > Tuukka > > > > > 2015-06-11 17:16 GMT+03:00 Daniel Schürmann <dasch...@mixxx.org>: >>> So we have people who prefer 80 columns, and people who prefer unlimited >>> columns. There's not really a compromise position between these two >>> options, so how do we choose? >> >> We have people who prefer 80 columns and we have people who prefer more. >> I prefer 80 columns. >> So there is no column issue issue to add a .clang-format file to the Mixxx >> source and ask any contributor to run it if there are style issues. >> >> The latest discussion was about the code cluttering produced by a >> unsupervised run at all Mixxx source. >> This happens because we allow currently allow more than 80 columns for >> reasons. >> >> Setting the columns to unlimited helps a bit. >> But there are still other cluttering issues that requires developer >> attention. >> >> >>> Never seen astyle has broke something like code didn't work anymore. >> >> Do you have experience with Astyle. Maybe this can be configured to be more >> temperate than clang-format. >> It would be also nice if we can do the mass auto-format for single style >> issues only e.g. the pinter * alignment. >> >> >> >> >> >> >> 2015-06-11 15:30 GMT+02:00 Owen Williams <owilli...@mixxx.org>: >>> >>> So we have people who prefer 80 columns, and people who prefer unlimited >>> columns. There's not really a compromise position between these two >>> options, so how do we choose? >>> >>> >>> On Wed, 2015-06-10 at 09:28 -0400, Owen Williams wrote: >>>> On Wed, 2015-06-10 at 09:16 -0400, RJ Ryan wrote: >>>>> >>>> >>>>> >>>>> >>>>> The part of clang-format which frees you from having to talk about >>>>> code style is that there is only one right way to format the code. >>>>> Letting the developer have any choice in the matter goes against this. >>>>> >>>> >>>> Agree. I don't really feel strongly about line length, so 80 is fine >>>> with me. >>>> >>>> >>>> >>>> >>>> ------------------------------------------------------------------------------ >>>> _______________________________________________ >>>> Get Mixxx, the #1 Free MP3 DJ Mixing software Today >>>> http://mixxx.org >>>> >>>> >>>> Mixxx-devel mailing list >>>> Mixxx-devel@lists.sourceforge.net >>>> https://lists.sourceforge.net/lists/listinfo/mixxx-devel >>>> >>>> >>> >>> >>> >>> >>> ------------------------------------------------------------------------------ >>> _______________________________________________ >>> Get Mixxx, the #1 Free MP3 DJ Mixing software Today >>> http://mixxx.org >>> >>> >>> Mixxx-devel mailing list >>> Mixxx-devel@lists.sourceforge.net >>> https://lists.sourceforge.net/lists/listinfo/mixxx-devel >> >> >> >> ------------------------------------------------------------------------------ >> >> _______________________________________________ >> Get Mixxx, the #1 Free MP3 DJ Mixing software Today >> http://mixxx.org >> >> >> Mixxx-devel mailing list >> Mixxx-devel@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/mixxx-devel > > ------------------------------------------------------------------------------ > _______________________________________________ > Get Mixxx, the #1 Free MP3 DJ Mixing software Today > http://mixxx.org > > > Mixxx-devel mailing list > Mixxx-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/mixxx-devel > ------------------------------------------------------------------------------ _______________________________________________ Get Mixxx, the #1 Free MP3 DJ Mixing software Today http://mixxx.org Mixxx-devel mailing list Mixxx-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mixxx-devel
