Hallo

I have got a bug report from Petr, he found in the mjpegtools RC2.

The patches look ok for me

Here is his mail:
I tried to compile the RC2 and encountered the following problems:

1) mjpegtools-1.9.0rc2/mpeg2enc/motionest.cc:1162:
        warning: 'dualp_mc$pos$y' is used uninitialized in this function

this is probably caused by a typo on line 695 (dpfield_estimate()) which
should probably read:
        bestdp_mc->pos.y = jmindmv;

instead of:
        bestdp_mc->pos.x = jmindmv;

btw: argument "bestsp_mc" seems to be unused in this function.

2) mjpegtools-1.9.0rc2/utils/cpu_accel.c:364,368:
        implicit declaration of 'memalign'

missing #include <malloc.h>

Patches for both are attached. Please confirm, whether the first one is
correct.

Best regards
        Petr Cerny



*** utils/cpu_accel.c   2007-05-04 19:59:36.555400500 +0200
--- utils/cpu_accel.c   2007-05-04 19:59:55.492584000 +0200
***************
*** 24,29 ****
--- 24,30 ----
   #include <signal.h>
   #include <setjmp.h>
   #include <stdlib.h>
+ #include <malloc.h>
   #include <unistd.h>
   #include <string.h>
   #include <errno.h>



--- mpeg2enc/motionest.cc.old   2007-05-04 20:44:44.656646250 +0200
+++ mpeg2enc/motionest.cc       2007-05-04 20:45:38.111987000 +0200
@@ -692,7 +692,7 @@
                        16);            /* block height */

        bestdp_mc->pos.x = imindmv;
-       bestdp_mc->pos.x = jmindmv;
+       bestdp_mc->pos.y = jmindmv;
        *vmcp = vmc_dp;
  }



auf hoffentlich bald,

Berni the Chaos of Woodquarter

Email: [EMAIL PROTECTED]
www: http://www.lysator.liu.se/~gz/bernhard

-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
Mjpeg-users mailing list
Mjpeg-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mjpeg-users

Reply via email to