On Wed, 3 Sep 2008, Jean Delvare wrote:
> The zr36067 driver is improperly declaring pixel format RGBP twice,
> once as "16-bit RGB LE" and once as "16-bit RGB BE". The latter is
> actually RGBR. Fix the code to properly map both pixel formats.
> Signed-off-by: Jean Delvare <[EMAIL PROTECTED]>
> Cc: Trent Piepho <[EMAIL PROTECTED]>
> Cc: Ronald S. Bultje <[EMAIL PROTECTED]>
> ---
> Trent, this bug was introduced by this patch of yours:
> http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=603d6f2c8f9f3604f9c6c1f8903efc2df30a000f
> which was merged in kernel 2.6.23. Can you please review and ack this
> fix? Thanks.

You're right, it looks like I missed the 'X' when I added this little used
format.  Does the pixfmt-test program in v4l2-apps check out ok?

Acked-by: Trent Piepho <[EMAIL PROTECTED]>

>
>  drivers/media/video/zoran_driver.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- linux-2.6.27-rc5.orig/drivers/media/video/zoran_driver.c  2008-09-03 
> 10:20:36.000000000 +0200
> +++ linux-2.6.27-rc5/drivers/media/video/zoran_driver.c       2008-09-03 
> 12:47:04.000000000 +0200
> @@ -134,7 +134,7 @@ const struct zoran_format zoran_formats[
>       }, {
>               .name = "16-bit RGB BE",
>               ZFMT(-1,
> -                  V4L2_PIX_FMT_RGB565, V4L2_COLORSPACE_SRGB),
> +                  V4L2_PIX_FMT_RGB565X, V4L2_COLORSPACE_SRGB),
>               .depth = 16,
>               .flags = ZORAN_FORMAT_CAPTURE |
>                        ZORAN_FORMAT_OVERLAY,
>
>
> --
> Jean Delvare
>

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
Mjpeg-users mailing list
Mjpeg-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mjpeg-users

Reply via email to