>-----Original Message----- >From: Jacopo Mondi <[email protected]> >Sent: Saturday, August 2, 2025 5:23 PM >To: Mauro Carvalho Chehab <[email protected]>; Devarsh Thakkar ><[email protected]>; Benoit Parrot <[email protected]>; Hans Verkuil ><[email protected]>; Mike Isely <[email protected]>; Laurent Pinchart ><[email protected]>; Hans de Goede <[email protected]>; >Parthiban Veerasooran <[email protected]>; Christian >Gromm <[email protected]>; Greg Kroah-Hartman ><[email protected]>; Alex Shi <[email protected]>; Yanteng Si ><[email protected]>; Dongliang Mu <[email protected]>; Jonathan >Corbet <[email protected]>; Tomasz Figa <[email protected]>; Marek >Szyprowski <[email protected]>; Andy Walls ><[email protected]>; Michael Tretter <[email protected]>; >Pengutronix Kernel Team <[email protected]>; Bin Liu ><[email protected]>; Matthias Brugger <[email protected]>; >AngeloGioacchino Del Regno <[email protected]>; >Dmitry Osipenko <[email protected]>; Thierry Reding ><[email protected]>; Jonathan Hunter <[email protected]>; >Mirela Rabulea <[email protected]>; Shawn Guo ><[email protected]>; Sascha Hauer <[email protected]>; Fabio >Estevam <[email protected]>; Kieran Bingham ><[email protected]>; Michal Simek ><[email protected]>; Ming Qian <[email protected]>; Eagle Zhou ><[email protected]>; Xavier Roumegue (OSS) ><[email protected]>; Philipp Zabel <[email protected]>; >Vikash Garodia <[email protected]>; Dikshita Agarwal ><[email protected]>; Abhinav Kumar <[email protected]>; >Bryan O'Donoghue <[email protected]>; Sylwester Nawrocki ><[email protected]>; Jernej Skrabec <[email protected]>; >Chen-Yu Tsai <[email protected]>; Samuel Holland <[email protected]>; >Daniel Almeida <[email protected]>; Neil Armstrong ><[email protected]>; Kevin Hilman <[email protected]>; Jerome >Brunet <[email protected]>; Martin Blumenstingl ><[email protected]>; Nas Chung ><[email protected]>; Jackson Lee ><[email protected]>; Minghsiu Tsai ><[email protected]>; Houlong Wei <[email protected]>; >Andrew-CT Chen <[email protected]>; Tiffany Lin ><[email protected]>; Yunfei Dong <[email protected]>; >Geert Uytterhoeven <[email protected]>; Magnus Damm ><[email protected]>; Mikhail Ulyanov ><[email protected]>; Jacob Chen <jacob- >[email protected]>; Ezequiel Garcia <[email protected]>; Heiko >Stuebner <[email protected]>; Detlev Casanova ><[email protected]>; Krzysztof Kozlowski <[email protected]>; >Alim Akhtar <[email protected]>; Sylwester Nawrocki ><[email protected]>; Łukasz Stelmach <[email protected]>; >Andrzej Pietrasiewicz <[email protected]>; Jacek Anaszewski ><[email protected]>; Andrzej Hajda <[email protected]>; >Fabien Dessenne <[email protected]>; Hugues Fruchet ><[email protected]>; Jean-Christophe Trotin <jean- >[email protected]>; Maxime Coquelin ><[email protected]>; Alexandre Torgue ><[email protected]>; Nicolas Dufresne ><[email protected]>; Benjamin Gaignard ><[email protected]>; Steve Longerbeam ><[email protected]>; Maxime Ripard <[email protected]>; Paul >Kocialkowski <[email protected]>; Niklas Söderlund ><[email protected]>; Robert Foss <[email protected]>; Todor >Tomov <[email protected]>; Vladimir Zapolskiy ><[email protected]>; Corentin Labbe <[email protected]>; >Sakari Ailus <[email protected]>; Bingbu Cao ><[email protected]>; Tianshu Qiu <[email protected]>; Stanislaw >Gruszka <[email protected]> >Cc: [email protected]; [email protected]; linux- >[email protected]; [email protected]; linux-arm- >[email protected]; [email protected]; linux- >[email protected]; [email protected]; [email protected]; >[email protected]; [email protected]; linux- >[email protected]; [email protected]; linux- >[email protected]; [email protected]; linux- >[email protected]; [email protected]; >Jacopo Mondi <[email protected]> >Subject: [EXT] [PATCH 13/65] media: amphion: Make some vpu_v4l2 functions >static > >Caution: This is an external email. Please take care when clicking links or >opening attachments. When in doubt, report the message using the 'Report >this email' button > > >From: Laurent Pinchart <[email protected]> > >Some functions defined in vpu_v4l2.c are never used outside of that >compilation unit. Make them static. > >Signed-off-by: Laurent Pinchart <[email protected]> >Signed-off-by: Jacopo Mondi <[email protected]>
Reviewed-by: Ming Qian <[email protected]> >--- > drivers/media/platform/amphion/vpu_v4l2.c | 12 +++++++++--- >drivers/media/platform/amphion/vpu_v4l2.h | 8 -------- > 2 files changed, 9 insertions(+), 11 deletions(-) > >diff --git a/drivers/media/platform/amphion/vpu_v4l2.c >b/drivers/media/platform/amphion/vpu_v4l2.c >index >74668fa362e24fd34829b500e99c8455a9413fc1..306d94e0f8e79faaacfa35b28e >5786860f7bd1ca 100644 >--- a/drivers/media/platform/amphion/vpu_v4l2.c >+++ b/drivers/media/platform/amphion/vpu_v4l2.c >@@ -24,6 +24,11 @@ > #include "vpu_msgs.h" > #include "vpu_helpers.h" > >+static char *vpu_type_name(u32 type) >+{ >+ return V4L2_TYPE_IS_OUTPUT(type) ? "output" : "capture"; } >+ > void vpu_inst_lock(struct vpu_inst *inst) { > mutex_lock(&inst->lock); >@@ -42,7 +47,7 @@ dma_addr_t vpu_get_vb_phy_addr(struct vb2_buffer >*vb, u32 plane_no) > vb->planes[plane_no].data_offset; } > >-unsigned int vpu_get_vb_length(struct vb2_buffer *vb, u32 plane_no) >+static unsigned int vpu_get_vb_length(struct vb2_buffer *vb, u32 >+plane_no) > { > if (plane_no >= vb->num_planes) > return 0; >@@ -81,7 +86,7 @@ void vpu_v4l2_set_error(struct vpu_inst *inst) > vpu_inst_unlock(inst); > } > >-int vpu_notify_eos(struct vpu_inst *inst) >+static int vpu_notify_eos(struct vpu_inst *inst) > { > static const struct v4l2_event ev = { > .id = 0, >@@ -573,7 +578,8 @@ static void vpu_vb2_buf_finish(struct vb2_buffer *vb) > call_void_vop(inst, on_queue_empty, q->type); } > >-void vpu_vb2_buffers_return(struct vpu_inst *inst, unsigned int type, enum >vb2_buffer_state state) >+static void vpu_vb2_buffers_return(struct vpu_inst *inst, unsigned int type, >+ enum vb2_buffer_state state) > { > struct vb2_v4l2_buffer *buf; > >diff --git a/drivers/media/platform/amphion/vpu_v4l2.h >b/drivers/media/platform/amphion/vpu_v4l2.h >index >56f2939fa84d07b7ea07e889ab5ad3bb7ca9ab5c..4a87b06ae520306ede356b6f >3309d8b4a67c204a 100644 >--- a/drivers/media/platform/amphion/vpu_v4l2.h >+++ b/drivers/media/platform/amphion/vpu_v4l2.h >@@ -26,15 +26,12 @@ void vpu_skip_frame(struct vpu_inst *inst, int count); >struct vb2_v4l2_buffer *vpu_find_buf_by_sequence(struct vpu_inst *inst, u32 >type, u32 sequence); struct vb2_v4l2_buffer *vpu_find_buf_by_idx(struct >vpu_inst *inst, u32 type, u32 idx); void vpu_v4l2_set_error(struct vpu_inst >*inst); -int vpu_notify_eos(struct vpu_inst *inst); int >vpu_notify_source_change(struct vpu_inst *inst); int >vpu_set_last_buffer_dequeued(struct vpu_inst *inst, bool eos); -void >vpu_vb2_buffers_return(struct vpu_inst *inst, unsigned int type, enum >vb2_buffer_state state); int vpu_get_num_buffers(struct vpu_inst *inst, u32 >type); bool vpu_is_source_empty(struct vpu_inst *inst); > > dma_addr_t vpu_get_vb_phy_addr(struct vb2_buffer *vb, u32 plane_no); - >unsigned int vpu_get_vb_length(struct vb2_buffer *vb, u32 plane_no); static >inline struct vpu_format *vpu_get_format(struct vpu_inst *inst, u32 type) { > if (V4L2_TYPE_IS_OUTPUT(type)) >@@ -43,11 +40,6 @@ static inline struct vpu_format *vpu_get_format(struct >vpu_inst *inst, u32 type) > return &inst->cap_format; } > >-static inline char *vpu_type_name(u32 type) -{ >- return V4L2_TYPE_IS_OUTPUT(type) ? "output" : "capture"; >-} >- > static inline int vpu_vb_is_codecconfig(struct vb2_v4l2_buffer *vbuf) { > #ifdef >V4L2_BUF_FLAG_CODECCONFIG > >-- >2.49.0 _______________________________________________ Mjpeg-users mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/mjpeg-users
