Hi

I compared the pbf and xml formats as output from a small file which only produced one output tile.

I converted the pbf to xml with osmosis. Its tricky to compare them, but by counting elements it seemed that the main differences was that there were fewer relations in the pbf output. Further more it just seemed to be the final few that were missing.

Comparing with the osmosis code I think there should be a switchTypes() call to ensure that the last relations are written out (see attached patch).

After the patch, I can't see any further substantial difference between the outputs. Compiled img files are the same size although not entirely identical. I'm not sure if the differences are significant or not yet.

There could still be bugs in the mkgmap pbf reader code. Although it has been in for a while, its probably not been used much until now.

..Steve
Index: src/uk/me/parabola/splitter/BinaryMapWriter.java
===================================================================
--- src/uk/me/parabola/splitter/BinaryMapWriter.java	(revision 173)
+++ src/uk/me/parabola/splitter/BinaryMapWriter.java	(revision )
@@ -498,8 +498,9 @@
   public void finishWrite()
   {
     try {
+		serializer.switchTypes();
-      serializer.processBatch();
-      serializer.close();
+		serializer.processBatch();
+		serializer.close();
     }
     catch(IOException e) {
       System.out.println("Could not write end of file: " + e);
_______________________________________________
mkgmap-dev mailing list
mkgmap-dev@lists.mkgmap.org.uk
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev

Reply via email to