Hi WanMil,
found it while coding a performance patch.
Sorry, my patch fixed only one of the two problems.
I think the code should search for tag keys containing the string name,
or it should use the name-tag-list.
It searches for tags endings with :name which is probably not useful?
Gerd
WanMil wrote
> Hi Gerd,
>
> you found a bug which exists since the SeaGenerator was invented (and
> nobody noticed it so far ;-).
>
> The effect is quite small. Only for some wrong coastline ways
> (anti-islands etc.) the internal error handling of the SeaGenerator
> copies this way and tries to keep the name of it. I think the intention
> is to be able to use the name of islands. This should work only if the
> style file handles this.
>
> I didn't test it further as I recommend to use precompiled sea and I
> think the SeaGenerator is deprecated...
>
> WanMil
>
>> Hi WanMil,
>>
>> please check:
>> SeaGenerator contains to places with this loop:
>> for(String tag : w)
>> if(tag.equals("name") ||
>> tag.endsWith(":name"))
>> w1.addTag(tag, w.getTag(tag));
>>
>> This will not work, because tag will contain the complete tag, something
>> like "name=XYZ" or "name:de=Rügen"
>>
>> Attached patch changes the code so that it works, but maybe it is better
>> to remove the lines?
>> I found no change in the output when using the patch.
>>
>> Gerd
>>
>>
>> _______________________________________________
>> mkgmap-dev mailing list
>>
> [email protected]
>> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
>>
>
> _______________________________________________
> mkgmap-dev mailing list
> [email protected]
> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
--
View this message in context:
http://gis.19327.n5.nabble.com/bug-in-SeaGenerator-tp5803398p5803442.html
Sent from the Mkgmap Development mailing list archive at Nabble.com.
_______________________________________________
mkgmap-dev mailing list
[email protected]
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
