Hi Gerd, thanks for the quick reply. I'm happy to post patch files for now.
I already posted one suggested change, although I didn't use the create
patch file option.
I have another small patch to improve the message when there are too many
POIS at the same place - two patch files attached.
As the change is only one line of code in each module, I suggest I skip
uploading a binary (I don't have one with only that change in it at
present).
Can I also suggest adding something to the developer web page indicating
that you have to be separately approved before you can upload code changes,
how to apply for approval and the procedure to follow before approval?
Cheers,
Mike
-----Original Message-----
Hi Mike,
I think Steve has to permit that you can commit directly to trunk.
I don't know if you are allowed to create a branch.
If you don't mind, I suggest to use this procedure for now:
1) post a patch file and upload a binary to
http://files.mkgmap.org.uk/
Let all users know what the patch does and wait for reports.
If we see positive feedback, you may want to
post a 2nd version to make sure that comments are okay,
unit tests are passed, doc files contain the new feature etc.
Finally one will commit your change.
If we get the feeling that you know what to do Steve will
probably give you write permits for trunk.
OK?
Gerd
--- C:/Users/mike/AppData/Local/Temp/MdrBuilder.java-revBASE.svn007.tmp.java
Tue Mar 4 22:44:24 2014
+++
C:/Users/mike/Documents/CreateIMG/src/mkgmap/src/uk/me/parabola/mkgmap/combiners/MdrBuilder.java
Wed Jan 7 00:34:21 2015
@@ -272,8 +272,7 @@ public class MdrBuilder implements Combiner {
for (Point p : list) {
Label label = p.getLabel();
if (p.getNumber() > 256) {
- // I think we limit the number of
points+ind-points, but just in case
- System.out.println("point number too big");
+ // error message already shown in
MapBuilder.java, so no need to repeat it
continue;
}
--- C:/Users/mike/AppData/Local/Temp/MapBuilder.java-revBASE.svn00f.tmp.java
Sun Dec 21 14:31:16 2014
+++
C:/Users/mike/Documents/CreateIMG/src/mkgmap/src/uk/me/parabola/mkgmap/build/MapBuilder.java
Wed Jan 7 00:50:15 2015
@@ -948,7 +948,7 @@ public class MapBuilder implements Configurable {
if(!point.hasExtendedType()) {
if(name != null && div.getZoom().getLevel() ==
0) {
if(pointIndex > 255)
- log.error("FIXME - too many
POIs in group");
+ log.error("Too many POIs at
location " + div.getCenter().toOSMURL() + " - " + name + " will be ignored");
else if(point.isExit()) {
Exit e =
((MapExitPoint)point).getExit();
if(e != null)
_______________________________________________
mkgmap-dev mailing list
mkgmap-dev@lists.mkgmap.org.uk
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
