Hi Ticker,
I think what confused me was the use of abbreviation cf (I did not know that)
and that seaSize is a named constant which means
it should be in upper case. See my changes in r4248.
There is another confusing comment in Way.java:
// this is unadulterated size, +ve if clockwise
I guess that +ve means positive? This is hard to understand for a non-native
speaker who grew up before SMS and Twitter and just learned to use smileys ;-)
Gerd
________________________________________
Von: mkgmap-dev <mkgmap-dev-boun...@lists.mkgmap.org.uk> im Auftrag von Ticker
Berkin <rwb-mkg...@jagit.co.uk>
Gesendet: Dienstag, 6. November 2018 10:43
An: Development list for mkgmap
Betreff: Re: [mkgmap-dev] New branch for default typ file
Hi Gerd
It's not the name of the map feature that I'm talking about; rather the
string representation of the type which my device displays, along with
the name, when the map feature is selected.
So, for instance, I'd like to use one of the other the Park
representations, say 0x20, for leisure=garden. In the TYP file I'd like
to set the String for this type, but don't want to override the colour
/ bitmap or whatever representation.
Concerning the background polygon, I want to set it's area to bigger
than the sea area, where the default is set in SeaGenerator.java with
the comment:
/**
* When order-by-decreasing-area we need all bit of sea to be output
consistently.
* Unless _draworder changes things, having seaSize as BIG causes
polygons beyond the
* coastline to be shown. To hide these and have the sea show up to the
high-tide
* coastline, can set this to be very small instead (or use
_draworder).
* <p>
* mkgmap:drawLevel can be used to override this value in the style -
the default style has:
* natural=sea { add mkgmap:skipSizeFilter=true; set mkgmap:drawLevel=2
} [0x32 resolution 10]
* which is equivalent to Long.MAX_VALUE-2.
*/
private static final long seaSize = Long.MAX_VALUE-2; // sea is BIG
I don't think having method just used by addBackground adds anything to
clarity. I could put a constant with MAX_VALUE-1 and comment into
MapperBasedMapDataSource instead if you'd prefer
Regards
Ticker
On Tue, 2018-11-06 at 00:16 -0600, Gerd Petermann wrote:
> Hi Ticker,
>
> Ticker Berkin wrote
> > Does anyone know if it would be possible to change mkgmap to allow
> > this?
>
> Not sure if this is what you want, did you try default_name?
> See e.g.
> amenity=emergency_phone [0x2f12 resolution 24 default_name 'Emergency
> Phone']
>
> I don't understand the comment in the patch:
> background.setFullArea(Long.MAX_VALUE-1); // cf:
> SeaGenerator.java:
> seaSize
> Wouldn't it be better to have a method named something like
> setAreaSizeToMax() ?
>
> Gerd
>
>
>
> --
> Sent from:
> http://gis.19327.n8.nabble.com/Mkgmap-Development-f5324443.html
> _______________________________________________
> mkgmap-dev mailing list
> mkgmap-dev@lists.mkgmap.org.uk
> http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
_______________________________________________
mkgmap-dev mailing list
mkgmap-dev@lists.mkgmap.org.uk
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
_______________________________________________
mkgmap-dev mailing list
mkgmap-dev@lists.mkgmap.org.uk
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev
