Hi Gerd, 

Both changes are fine by me. The "Invalid mapname" message I had put as a
warning only because of the preceding comment "Although its not necessarily
wrong for them to be zero, it probably (is a) sign that something is wrong"
- I have no strong conviction about the severity, and it is probably a
message no-one has ever seen.

Cheers,
Mike

-----Original Message-----
From: Gerd Petermann [mailto:gpetermann_muenc...@hotmail.com] 
Sent: 11 April 2021 16:08
To: Development list for mkgmap <mkgmap-dev@lists.mkgmap.org.uk>
Subject: Re: [mkgmap-dev] More logging

Hi Mike,


I think MdxFile should use Logger.defaultLogger.error() and maybe
LblFileReader should use Logger.defaultLogger.warn()
(as in attached patch)..
Just my feeling, can't prove anything.

Gerd

________________________________________
Von: mkgmap-dev <mkgmap-dev-boun...@lists.mkgmap.org.uk> im Auftrag von Mike
Baggaley <m...@tvage.co.uk>
Gesendet: Sonntag, 11. April 2021 16:10
An: 'Development list for mkgmap'
Betreff: [mkgmap-dev] More logging

Hi Gerd,

Here is the next patch. This one moves a number of messages from writing to
stdout/err to using logging. There are several files changed, but most have
only very small changes.

I'd be interested to know what the message "Map has tide prediction, please
implement" in LBLFileReader means...

Cheers,
Mike

_______________________________________________
mkgmap-dev mailing list
mkgmap-dev@lists.mkgmap.org.uk
http://www.mkgmap.org.uk/mailman/listinfo/mkgmap-dev

Reply via email to