Follow-up Comment #17, patch #5599 (project mldonkey):
im not right, with merging of the modules it should be able to communicate in
64bit only. i changed your patch to better reflect this ability.
but i found a logical error too.
256gb_4.patch line#207f
+ let is_largefile = file_is_largefile file || check_large ranges in
+ if is_largefile && c.client_emule_proto.emule_largefiles <> 1 then
this is not correct in this form, atm 64bit should only be used in cases,
where ranges above old_emule_max_size are used, not in general, the logical
or is the mistake, should be logical and. but in case that check_large ranges
is true, file_is_largefile file should be true too, so this is redundant. i
changed it to:
+ let is_large_request = check_large ranges in
+ if file_is_largefile file && c.client_emule_proto.emule_largefiles <> 1
then
in 256gb_5.patch
(file #11415)
_______________________________________________________
Additional Item Attachment:
File name: 256gb_5.patch Size:29 KB
_______________________________________________________
Reply to this item at:
<http://savannah.nongnu.org/patch/?5599>
_______________________________________________
Message sent via/by Savannah
http://savannah.nongnu.org/
_______________________________________________
Mldonkey-users mailing list
[email protected]
http://lists.nongnu.org/mailman/listinfo/mldonkey-users
