-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 forgot to cc ml...
- -------- Original Message -------- Subject: Re: [Mlt-devel] [Patch] Frei0r string parameter Date: Mon, 18 Oct 2010 10:37:47 +0200 From: Till Theato <[email protected]> To: Dan Dennedy <[email protected]> On 10/18/2010 06:46 AM, Dan Dennedy wrote: > On Sun, Oct 17, 2010 at 2:56 AM, Till Theato <[email protected]> wrote: >> -----BEGIN PGP SIGNED MESSAGE----- >> Hash: SHA1 >> >> Hi, >> the attached patch adds support for the frei0r string parameter. >> There currently is no filter using this, but I plan to work on one. > > Based on the patch I just sent to the frei0r list, this patch would > not work as is. You would have to do something like: > > f0r_param_string val = mlt_properties_get(prop, pinfo.name); > if (val) f0r_set_param_value(inst, &val, i); > Here is what the relevant parts of my f0r_set_param_value looked like: char *tmp = (f0r_param_string *)param; if (strcmp(inst->string, tmp) != 0) { inst->string = strdup(tmp); updateMap(instance); } Now I changed the first line to make it work again: f0r_param_string tmp = *((f0r_param_string *)param); ... Would this then be the preferred way to set string parameters? regards Till -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAky8DXEACgkQzwEyz7QP6nTaCQCbBuCvI/frYom7eZn8u23Sydi1 JCwAn16r+6lDb2vFCBPyY8CMTPwOvnAH =SP6i -----END PGP SIGNATURE----- ------------------------------------------------------------------------------ Download new Adobe(R) Flash(R) Builder(TM) 4 The new Adobe(R) Flex(R) 4 and Flash(R) Builder(TM) 4 (formerly Flex(R) Builder(TM)) enable the development of rich applications that run across multiple browsers and platforms. Download your free trials today! http://p.sf.net/sfu/adobe-dev2dev _______________________________________________ Mlt-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/mlt-devel
