Hi Dan, I have resolved all your comments below in this commit: https://github.com/pez4brian/mlt/commit/29ac2c1f15e10cb992872d5022f1a795c3839497
The original commit is here: https://github.com/pez4brian/mlt/commit/a6b48d08e789be43262e2ef01c11a0af72a58d1b Let me know if you have any further comments. Thanks, ~Brian >Here are some changes I would like. >1) Replace 'this' with 'filter' (preferred) or 'self' (if filter >already used). 'this' messes up my IDE because it is a C++ thing. >Yeah, I know it is used often elsewhere, but I have not got around to >fixing it everywhere! > >2) yaml says // is escape, but it is \ > >3) call get_filter in init and return null if get_filter returns null >for some reason. That function does not depend on any properties being >set after init, so load it right away. > >4) in get_filter, use "pango:" instead of "+.txt" to make it more >clear and direct > >5) we now prefer not to compare to NULL and instead use if( pointer ) >or if ( !pointer) > >6) in init, let "text" be supplied by the arg arg if supplied and >default to "#timecode#" otherwise ------------------------------------------------------------------------------ BlackBerry® DevCon Americas, Oct. 18-20, San Francisco, CA http://p.sf.net/sfu/rim-devcon-copy2 _______________________________________________ Mlt-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/mlt-devel
