Christian, I updated the unit test to exercise the new change set for 7001379.
The test now exercises a second BSM ("bsm2") which gets passed extra arguments
from the BootstrapMethods classfile attribute.
Would you mind doing a quick re-review?
http://cr.openjdk.java.net/~jrose/7001423/webrev.01/
-- John
On Nov 23, 2010, at 2:21 AM, Christian Thalinger wrote:
> On Nov 21, 2010, at 9:40 AM, John Rose wrote:
>> This webrev has a small jtreg test for the hotspot repository.
>>
>> http://cr.openjdk.java.net/~jrose/7001423/webrev.00/
>>
>> It exercises the invokedynamic instruction, making the the bootstrap method
>> parameters are made available to the BSM, and ensuring that the resulting
>> call site can be invoked as expected.
>>
>> (Not included, to be done later: Multiple invocation of dynamic call sites,
>> additional bootstrap method parameters, "ldc" of MethodHandle and MethodType
>> constants.)
>>
>> In order to introduce an invokedynamic instruction (without help from the
>> compiler), this unit test comes with a medium-sized script (single-file Java
>> program) called "Indify" which generates the instruction in the test file.
>>
>> The Indify script is described here:
>> http://blogs.sun.com/jrose/entry/a_modest_tool_for_writing
>>
>> In later pushes, Indify will be re-used for additional unit tests (such as
>> those mentioned above to be done later).
>
> I haven't looked closely at the changes (especially Indify) but it seems good.
>
> -- Christian
_______________________________________________
mlvm-dev mailing list
[email protected]
http://mail.openjdk.java.net/mailman/listinfo/mlvm-dev
