On Apr 5, 2011, at 4:32 PM, Gary Benson wrote: > Christian Thalinger wrote: >> On Apr 5, 2011, at 4:04 PM, Gary Benson wrote: >>> Christian Thalinger wrote: >>>> hotspot/src/share/vm/interpreter/bytecodeInterpreter.cpp: >>>> >>>> + assert(false, "Should have thrown incompatible class change >>>> exception"); >>>> >>>> I'd use ShouldNotReachHere instead. >>> >>> That happens in a lot of places in BytecodeInterpreter::run. How >>> about I make another webrev that changes them all? >> >> In the current version? I only find one at line 1722. > > Oh, I thought there were more. Since there's only one, how about I > make another webrev with all three changed? I agree that a SNRH is > preferable to assert(false, ...
Sounds good to me. -- Christian _______________________________________________ mlvm-dev mailing list [email protected] http://mail.openjdk.java.net/mailman/listinfo/mlvm-dev
