I removed DEBUG_NAME completely...so it was not set to anything.
On Thu, Nov 10, 2011 at 3:07 PM, Henri Gomez <henri.go...@gmail.com> wrote: > And you didn't set DEBUG_NAME ? > > Le 10 nov. 2011 à 14:28, Charles Oliver Nutter <head...@headius.com> a écrit : > >> Ok, I think I figured out the problem. >> >> Stephen's build includes DEBUG_NAME and SKIP_FASTDEBUG_BUILD in the >> default set of variables, around line 199 in update.sh. The problem >> seems to be that if DEBUG_NAME is set to "fastdebug" that's the target >> used to build the JDK. Setting the other flags doesn't seem to have >> any effect then. >> >> I removed that line and set SKIP_FASTDEBUG_BUILD and SKIP_DEBUG_BUILD >> both to "true", and it has built a "product" build now instead. >> >> FWIW, I also cranked HOTSPOT_BUILD_JOBS up to 8 for my 4-core i7 (8 >> with hyperthreading) and the build goes much faster. >> >> system ~/projects/mlvm/sources $ build/bsd-amd64/j2sdk-image/bin/java >> -version >> openjdk version "1.8.0-internal" >> OpenJDK Runtime Environment (build >> 1.8.0-internal-headius_2011_11_10_14_11-b00) >> OpenJDK 64-Bit Server VM (build 23.0-b03, mixed mode) >> >> The product build is >> definitely faster at starting up and running JRuby benchmarks (first >> with Henri's fastdebug .dmg, then with my product build): >> >> system ~/projects/jruby $ time jruby -v >> jruby 1.7.0.dev (ruby-1.8.7-p330) (2011-11-07 8e852ac) (OpenJDK 64-Bit >> Server VM 1.8.0-b11-fastdebug) [darwin-amd64-java] >> >> real 0m1.999s >> user 0m2.106s >> sys 0m0.083s >> >> system ~/projects/jruby $ jruby bench/bench_fib_complex.rb >> normal fib 28.0 (±7.1%) i/s - 136 in >> 4.883273s (cycle=2) >> fib with variables 28.2 (±0.0%) i/s - 142 in >> 5.033941s (cycle=2) >> fib with constants 21.2 (±4.7%) i/s - 106 in >> 5.006481s (cycle=1) >> fib with additional calls >> 21.3 (±0.0%) i/s - 107 in >> 5.030669s (cycle=1) >> fib with constants and additional calls >> 19.0 (±10.5%) i/s - 94 in >> 5.007942s (cycle=1) >> >> system ~/projects/jruby $ export >> JAVA_HOME=/Users/headius/projects/mlvm/sources/build/bsd-amd64/j2sdk-image >> >> system ~/projects/jruby $ time jruby -v >> jruby 1.7.0.dev (ruby-1.8.7-p330) (2011-11-07 8e852ac) (OpenJDK 64-Bit >> Server VM 1.8.0-internal) [darwin-amd64-java] >> >> real 0m0.514s >> user 0m0.518s >> sys 0m0.049s >> >> system ~/projects/jruby $ jruby bench/bench_fib_complex.rb >> normal fib 31.4 (±3.2%) i/s - 159 in >> 5.062433s (cycle=3) >> fib with variables 30.0 (±3.3%) i/s - 150 in >> 4.999186s (cycle=3) >> fib with constants 23.3 (±0.0%) i/s - 118 in >> 5.069851s (cycle=2) >> fib with additional calls >> 23.7 (±0.0%) i/s - 120 in >> 5.059472s (cycle=2) >> fib with constants and additional calls >> 21.5 (±0.0%) i/s - 108 in >> 5.029512s (cycle=2) >> >> - Charlie >> >> On Wed, Nov 9, 2011 at 3:15 PM, Henri Gomez <henri.go...@gmail.com> wrote: >>> 2011/11/9 Henri Gomez <henri.go...@gmail.com>: >>>> 2011/11/9 Charles Oliver Nutter <head...@headius.com>: >>>>> On Wed, Nov 9, 2011 at 8:35 AM, Henri Gomez <henri.go...@gmail.com> wrote: >>>>>> I'm wondering about make flags to pass to have fastdebug enabled or >>>>>> disabled. >>>>>> >>>>>> for now, I'm using : >>>>>> >>>>>> DEBUG_NAME=fastdebug SKIP_FASTDEBUG_BUILD=true >>>>> >>>>> I believe you just need to set SKIP_FASTDEBUG_BUILD=false to get a >>>>> release build. It's a very confusing name. >>>> >>>> Yes. >>>> >>>> I'll try it right now >>> >>> It's unclear. >>> >>> settings SKIP_FASTDEBUG_BUILD to false produce a j2sdk-image under >>> sources/build/bsd-amd64-fastdebug instead of sources/build/bsd-amd64 >>> And even if I set DEBUG_NAME to release instead of fastdebug. >>> >>> I'm puzzled and need some clarifications :) >>> _______________________________________________ >>> mlvm-dev mailing list >>> mlvm-dev@openjdk.java.net >>> http://mail.openjdk.java.net/mailman/listinfo/mlvm-dev >>> >> _______________________________________________ >> mlvm-dev mailing list >> mlvm-dev@openjdk.java.net >> http://mail.openjdk.java.net/mailman/listinfo/mlvm-dev > _______________________________________________ > mlvm-dev mailing list > mlvm-dev@openjdk.java.net > http://mail.openjdk.java.net/mailman/listinfo/mlvm-dev > _______________________________________________ mlvm-dev mailing list mlvm-dev@openjdk.java.net http://mail.openjdk.java.net/mailman/listinfo/mlvm-dev