Hi Remy,
Am 11.07.2012 um 22:48 schrieb Rémi Forax:
> Hi Mickael,
> some minor comments,
> makeSignature should use a StringBuilder and not a StringBuffer.
good point, thanks!
> ans I don't think generateConcreteBMHClass needs to return a Class<?
> extends BoundMethodHandle>,
> a Class<?> seems enough so the cast near the end of the method can be
> removed.
I'd like to keep that to make really clear what Class type instances are
expected.
(There are places where Class<?> would just feel very wrong.)
Best,
Michael
--
Dr. Michael Haupt | Principal Member of Technical Staff
Phone: +49 331 200 7277 | Fax: +49 331 200 7561
Oracle Labs
Oracle Deutschland B.V. & Co. KG, Schiffbauergasse 14 | 14467 Potsdam, Germany
Oracle is committed to developing practices and products that help
protect the environment
_______________________________________________
mlvm-dev mailing list
mlvm-dev@openjdk.java.net
http://mail.openjdk.java.net/mailman/listinfo/mlvm-dev
