Reviewed. This is not a requirement, but I would prefer (in general) to see less test logic in ASM-generated bytecode and more in Java. I am guessing that the invokeExact call could have been replaced by a simple weakly-typed invoke call in the framing code, and likewise with most of the other invokes (methodType, findSpecial) which are not caller-sensitive.
— John On Jun 5, 2014, at 3:25 PM, Vladimir Ivanov <vladimir.x.iva...@oracle.com> wrote: > Thanks for review, Paul. > >> >> Looks ok. >> >> The behaviour of MethodHandles.Lookup.findSpecial got me confused for a >> while :-) >> >> Minor point: is it also worth exposing a T3.lookup() method and on the >> returned Lookup calling findSpecial(T1.class, "m", >> MethodType.methodType(int.class), T3.class).invokeExact() to ensure the >> programmatic path also works? > Good point. Updated webrev: > http://cr.openjdk.java.net/~vlivanov/8032400/webrev.01/ > > Best regards, > Vladimir Ivanov > _______________________________________________ > mlvm-dev mailing list > mlvm-dev@openjdk.java.net > http://mail.openjdk.java.net/mailman/listinfo/mlvm-dev _______________________________________________ mlvm-dev mailing list mlvm-dev@openjdk.java.net http://mail.openjdk.java.net/mailman/listinfo/mlvm-dev
