+1 to both. On Sep 9, 2014, at 3:22 PM, Vladimir Ivanov <vladimir.x.iva...@oracle.com> wrote:
>>> http://cr.openjdk.java.net/~vlivanov/8057657/webrev.00/ >>> https://bugs.openjdk.java.net/browse/JDK-8057657 >>> >> >> - BoundMethodHandle >> >> 57 assert(speciesData() == speciesData(form)); >> >> I am missing some context here as to how that assert would pass for anything >> other than Species_L, namely for sub-classes of BoundMethodHandle generated >> by generateConcreteBMHClass how does that assert return true? > Good catch, Paul. This assert should go with new bind implementation. Moved > the assert & speciesData(LambdaForm) from this change to 8057042 [1]. Updated > webrev in place. > Ok, i see how it wires up now, plus i suspected it might be some patch cross talk. Paul. >> 153 public static SpeciesData speciesData(LambdaForm form) { >> >> Minor point. Could be private (since only used by the assert in the >> constructor), or package private if the intention is for it to be used by >> other j.l.i classes in the future. > Made the method package-private. It is also used in LambdaFormEditor ( see > oldSpeciesData() [1]). > > Best regards, > Vladimir Ivanov > > [1] http://cr.openjdk.java.net/~vlivanov/8057042/webrev.00/
signature.asc
Description: Message signed with OpenPGP using GPGMail
_______________________________________________ mlvm-dev mailing list mlvm-dev@openjdk.java.net http://mail.openjdk.java.net/mailman/listinfo/mlvm-dev
