Revision: 14d45f19e514
Author: Jean Deruelle <[email protected]>
Date: Wed Aug 1 07:09:12 2012
Log: Adding non regression test for bad pwd
http://code.google.com/p/sipservlets/source/detail?r=14d45f19e514
Modified:
/sip-servlets-test-suite/testsuite/src/test/java/org/mobicents/servlet/sip/testsuite/TestSipListener.java
/sip-servlets-test-suite/testsuite/src/test/java/org/mobicents/servlet/sip/testsuite/security/ShootmeSipServletAuthTest.java
=======================================
---
/sip-servlets-test-suite/testsuite/src/test/java/org/mobicents/servlet/sip/testsuite/TestSipListener.java
Mon Jul 2 19:33:14 2012
+++
/sip-servlets-test-suite/testsuite/src/test/java/org/mobicents/servlet/sip/testsuite/TestSipListener.java
Wed Aug 1 07:09:12 2012
@@ -345,6 +345,7 @@
private RFC5626UseCase rfc5626UseCase;
private String securityUser = "user";
+ private String securityPwd = "pass";
class MyEventSource implements Runnable {
private TestSipListener notifier;
@@ -1878,7 +1879,7 @@
throw new IllegalArgumentException("Cannot create the INVITE
request",e);
}
// non regression test for
http://code.google.com/p/sipservlets/issues/detail?id=88
- if(securityUser.equalsIgnoreCase("badUser") && cSeq.getSeqNumber() > 2)
{
+ if((securityUser.equalsIgnoreCase("badUser") ||
securityPwd.equalsIgnoreCase("badpwd")) && cSeq.getSeqNumber() > 2) {
return null;
}
requestauth.setHeader(cSeq);
@@ -1913,7 +1914,7 @@
((WWWAuthenticate) (response
.getHeader(SIPHeaderNames.WWW_AUTHENTICATE))),
securityUser,
- "pass",
+ securityPwd,
((WWWAuthenticate) (response
.getHeader(SIPHeaderNames.WWW_AUTHENTICATE))).getNonce(),
1);
@@ -3433,4 +3434,8 @@
public void setSecurityUser(String securityUser) {
this.securityUser = securityUser;
}
-}
+
+ public void setSecurityPwd(String securityPwd) {
+ this.securityPwd = securityPwd;
+ }
+}
=======================================
---
/sip-servlets-test-suite/testsuite/src/test/java/org/mobicents/servlet/sip/testsuite/security/ShootmeSipServletAuthTest.java
Wed Jun 6 12:51:00 2012
+++
/sip-servlets-test-suite/testsuite/src/test/java/org/mobicents/servlet/sip/testsuite/security/ShootmeSipServletAuthTest.java
Wed Aug 1 07:09:12 2012
@@ -148,6 +148,28 @@
assertFalse(sender.getOkToByeReceived());
assertEquals(401, sender.getFinalResponseStatus());
}
+
+ // Testing bad pwd making sure it returns 401
+ public void testShootmeBadPassword() throws InterruptedException,
SipException,
+ ParseException, InvalidArgumentException {
+ String fromName = "sender";
+ String fromSipAddress = "sip-servlets.com";
+ SipURI fromAddress =
senderProtocolObjects.addressFactory.createSipURI(
+ fromName, fromSipAddress);
+
+ String toUser = "receiver";
+ String toSipAddress = "sip-servlets.com";
+ SipURI toAddress =
senderProtocolObjects.addressFactory.createSipURI(
+ toUser, toSipAddress);
+
+ sender.setSecurityPwd("badpwd");
+ sender.sendSipRequest("INVITE", fromAddress, toAddress, null,
null,
+ false);
+ Thread.sleep(TIMEOUT);
+ assertFalse(sender.isAckSent());
+ assertFalse(sender.getOkToByeReceived());
+ assertEquals(401, sender.getFinalResponseStatus());
+ }
@Override
protected void tearDown() throws Exception {