Yes, I pushed my fix to release/1.2.2 yesterday.

—Jens

On Apr 17, 2016, at 3:05 AM, David Quon 
<[email protected]<mailto:[email protected]>> wrote:

Hi Jens.  Looks like we found the same problem as you.  We fixed it on our fork 
https://github.com/amco/couchbase-lite-ios/commits/release/1.0.4 and everything 
now works as expected for us.  I'd be happy to verify your fix if it differs 
from ours.  Would your fix be able to make it into `1.2.2` or future builds?  
Thanks for your help as always as it's greatly appreciated.

On Saturday, April 16, 2016 at 7:04:16 PM UTC-7, Jens Alfke wrote:

On Apr 15, 2016, at 6:02 PM, David Quon <[email protected]<javascript:>> 
wrote:

Thanks for the explanation Jens.  So we tested with `release/1.2.2` 
(unofficial) and we're noticing that the replication is pulling everything (or 
it seems) and not just the `documentIDs` requested.  Also the replication does 
replicate a lot of documents (807 when we only requested 693) before just 
hanging and replication never finished.  Are these known issues?

That’s weird because the developer who reported the bug verified that the patch 
fixed it…

…Oh, I think I see. The initial report wasn’t about replicating a set of 
documentIDs, just regular replication. There still seems to be an 
incompatibility with replicating documentIDs: the CouchDB 
docs<http://docs.couchdb.org/en/latest/api/database/changes.html#post--db-_changes>
 show the ‘filter’ property stays in the URL, and only the  ‘docIDs’ parameter 
goes in the POST body, but we still put ‘filter’ only in the body. (I swear 
this isn’t our fault; we implemented POST to _changes before CouchDB did, and 
documented the API. My guess is they implemented it without looking at our 
docs.)

I’m working on a patch … should have it pushed to that branch in 10 minutes or 
so. Let me know if it works for you.

—Jens

--
You received this message because you are subscribed to the Google Groups 
"Couchbase Mobile" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to 
[email protected]<mailto:[email protected]>.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/mobile-couchbase/5ae97dab-e728-45a1-ae48-8bb848f0d07f%40googlegroups.com<https://groups.google.com/d/msgid/mobile-couchbase/5ae97dab-e728-45a1-ae48-8bb848f0d07f%40googlegroups.com?utm_medium=email&utm_source=footer>.
For more options, visit https://groups.google.com/d/optout.

-- 
You received this message because you are subscribed to the Google Groups 
"Couchbase Mobile" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/mobile-couchbase/50A5C117-1A8E-494F-B1C4-875FC516D446%40couchbase.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to