On Wed, Jun 5, 2013 at 11:11 AM, Jim Chen <[email protected]> wrote: > > > This also seems like a good list of things to check before posting your > own > > patches for review, especially for new contributors. If you can think of > > anything missing from this list, please add it, and we can wikify it for > > posterity later this week! > > I think a subset of the list would be good for new contributors. It's > definitely a useful guide for new contributors, but we don't want to > intimidate them either with a large list that they must follow. >
Yes, that's a good point. I don't think we should require new people to look at this list (after all, that's what review is for), but making this list available for anyone to look at can help contributors become better patch writers. Maybe we can organize this list so there's a section (or a separate page) specifically aimed at new contributors, which would include common newcomer gotchas like using tabs instead of spaces. Margaret
_______________________________________________ mobile-firefox-dev mailing list [email protected] https://mail.mozilla.org/listinfo/mobile-firefox-dev
