On 18/09/2014 23:54, Nick Alexander wrote:
On 2014-09-18, 3:28 PM, Jonathan Watt wrote:
To be clear, this wasn't a Try build, but an actual beta branch build.
It just isn't an actual milestone (as in b2, b4, etc.). So I'm assuming
you're saying that beta milestone builds are signed with the Release
key, but all other beta builds are not.
I don't know what beta branch build means, exactly,
I mean builds from these pushes:
https://tbpl.mozilla.org/?tree=Mozilla-Beta
but I don't think
that's important. The question is whether the build job (in the
buildbot sense) is configured as a beta/release job; that's where the
signing infrastructure is configured, I think. bhearsum is the expert
on this, I believe.
I do not think we want to be signing many builds with Mozilla's very
valuable release key, so I wouldn't want to see too many "beta branch
builds" signed as release/beta.
I'm not proposing a change to the signing, but rather a change to
MOZ_ANDROID_SHARED_ID to match the signing.
So to me it seems like we should have parity here:
https://mxr.mozilla.org/mozilla-central/source/mobile/android/defs.mk?rev=8c483fd63cad&mark=13-15
where we should only be using the "org.mozilla.firefox.sharedID" ID for
beta _milestones_ though, and using "org.mozilla.firefox_beta.sharedID"
(or whatever) for other beta builds. That would remove the pain point of
having to uninstall Release and milestone Betas in order to install and
test non-milestone betas. 'coz that kinda sucks.
If you can distinguish between milestone and branch builds in tree, I
have no objections to reviewing a patch that makes this simpler.
I'll look into it, thanks.
Jonathan
_______________________________________________
mobile-firefox-dev mailing list
[email protected]
https://mail.mozilla.org/listinfo/mobile-firefox-dev