Hello, everyone! I realized I never emailed the article out that I spoke about during our front-end meeting about some style best practices so here it is: [1].
To add to that... *tldr; Android inconsistently styles the default text appearance across different API levels so all TextAppearances should inherit from a common TextAppearance style.* I recently revised the styles on the share overlay [2] and created new TextAppearance styles without inheritance to use for the overlay because it seemed like our default "TextAppearance" was full of unnecessary values and it seemed cleaner to start over. It looked great on my N4 using Android L but ended up looking inconsistent on my 4.4 N7 [3]. Because we can't count on Android to provide us with consistent defaults, it is worth inheriting from our own base style for all TextAppearances, even if you think you're overriding all the values. This can be done by prefixing the TextAppearance name with "TextAppearance.", e.g. "TextAppearance.ShareOverlay". Note that TextViews without a specified TextAppearance will inherit from the base "TextAppearance" by default [4]. Let me know if you have questions. - Mike (:mcomella) [1]: http://blog.danlew.net/2014/11/19/styles-on-android/ [2]: https://bugzilla.mozilla.org/show_bug.cgi?id=1130203 [3]: https://bugzilla.mozilla.org/show_bug.cgi?id=1148041 [4]: https://mxr.mozilla.org/mozilla-central/source/mobile/android/base/resources/values/themes.xml?rev=75204e00b8cd#58
_______________________________________________ mobile-firefox-dev mailing list [email protected] https://mail.mozilla.org/listinfo/mobile-firefox-dev
