I filed a separate bug for the FxA link problem:
https://bugzilla.mozilla.org/show_bug.cgi?id=1259748
Who wants to fork my PR branch and put a fix for the link errors on top of
that? I think we need to see all tests green before we have a good feeling
about this migration.
Most warnings are gone now. I did not use the migrator and instead looked
at things manually.
The biggest change was the new #selector() syntax. This is a big commit. It
looks good but there are some warnings left about the case where it
suggested to convert "SELfoo:" to Selector("SELfoo:") instead of
#selector() - the warnings are all saying 'this selector does not actually
exist in the application' - I don't know if that is a compiler issue or a
bug on our part.
Did not touch the 'var arguments are deprecated' and '++ will be
deprecated' bugs yet. I think those need some more detailed attention
because they need actual code rewrites.
S.
On Fri, Mar 25, 2016 at 9:29 AM, Stefan Arentz <[email protected]> wrote:
> I've started yet another PR with Swift 2.2 changes. This builds on work
> from Richard and Emily.
>
> https://github.com/mozilla/firefox-ios/pull/1667/commits
> https://bugzilla.mozilla.org/show_bug.cgi?id=1246445
>
> With this branch you can build and run the app in the simulator. So we can
> all upgrade and not be blocked on toolchain issues.
>
> However, there are still some link errors around FxA in tests. I have not
> fixed those because I don't understand the cause. So instead I have
> disabled building tests in the Fennec scheme. This also speeds up
> compilation time in general so it may be a change we want to keep more
> permanently.
>
> So as a first step, let's deal with all the warnings about deprecated
> language features and changes. Then as a followup bug we an address link
> errors.
>
> Keep an eye on that PR, I think I'll have all warnings gone pretty soon.
>
> Weekend hacking,
>
> S.
>
>
_______________________________________________
mobile-firefox-dev mailing list
[email protected]
https://mail.mozilla.org/listinfo/mobile-firefox-dev
