Bob Ippolito wrote:
>
> On Jun 18, 2006, at 2:12 PM, whit wrote:
>
>> *From: *whit <[EMAIL PROTECTED] <mailto:[EMAIL PROTECTED]>>
>> *Date: *June 18, 2006 1:35:41 PM PDT
>> *Subject: **pulsate patch*
>>
>>
>> poking around on trunk. patch fixes missing 'this'.
>>
>> -w
>> Index: Visual.js
>> ===================================================================
>> --- Visual.js (revision 1027)
>> +++ Visual.js (working copy)
>> @@ -1630,7 +1630,7 @@
>> duration: 3.0,
>> from: 0,
>> afterFinishInternal: function (effect) {
>> - d.setStyle(effect.element, {opacity: oldOpacity});
>> + d.setStyle(effect.element, {opacity: this.oldOpacity});
>> }
>> }, options || {});
>> var oldOpacity = d.getInlineOpacity(element);
>
> That patch is incorrect, it doesn't fix anything. oldOpacity is in the
> closure, not on "this" (and even if it was on "this", it would still
> be wrong because it's in a different function).
>
> -b
ugh...actually it just breaks more stuff. this explains why I got
different errors after my edit. my bad for hastily misdiagnosing.
I originally got this error on the packed version, and after changing
the the variable oldOpacity in the closure to match the variable that is
created for oldOpacity during packing, I get no errors and pulsation as
expected (see patch).
Hope this helps.
-w
--
| david "whit" morriss
|
| contact :: http://public.xdi.org/=whit
"If you don't know where you are,
you don't know anything at all"
Dr. Edgar Spencer, Ph.D., 1995
"I like to write code like
other ppl like to tune their
cars or 10kW hifi equipment..."
Christian Heimes, 2004
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"MochiKit" group.
To post to this group, send email to mochikit@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at http://groups.google.com/group/mochikit
-~----------~----~----~----~------~----~------~--~---
Index: MochiKit.js
===================================================================
--- MochiKit.js (revision 1027)
+++ MochiKit.js (working copy)
@@ -5608,7 +5608,7 @@
var b=MochiKit.Base;
_780=d.getElement(_780);
_781=b.update({duration:3,from:0,afterFinishInternal:function(_782){
-d.setStyle(_782.element,{opacity:oldOpacity});
+d.setStyle(_782.element,{opacity:_783});
}},_781||{});
var _783=d.getInlineOpacity(_780);
var _784=_781.transition||v.Transitions.sinoidal;
begin:vcard
fn:D. Whitfield Morriss
n:Morriss;D. Whitfield
email;internet:[EMAIL PROTECTED]
tel;home:615 292-9142
tel;cell:415 710-8975
x-mozilla-html:FALSE
version:2.1
end:vcard
