On Tue, 2015-09-01 at 14:16 +0100, Raul Suarez Moreno wrote:
> On Tue, Sep 1, 2015 at 1:05 PM, Aleksander Morgado <aleksan...@aleksander.es
> > wrote:
>
> > >
> > > Sorry, that was my fault. I attach here the full ModemManager debug log
> > just
> > > from the system booting until the modem enabling process finished. I got
> > it
> > > after applying Daniels patch, so don't know if anything may be different.
> >
> > So the modem is indeed being detected as LTE, so that's not the issue.
> > I actually checked where the "EPS supported" flag comes from, and we
> > don't really set it anywhere during runtime, it's just a plugin
> > targeted setting (E.g. Altair LTE sets it to TRUE and resets CS/PS to
> > FALSE). So forget about what I previously said :)
> >
> > > Should I do any checking about Dans patch?
> >
> > Now, these new logs that Dan added may be indeed useful. But we need a
> > longer run from the logs. Can you re-run it with the patch and e.g.
> > try to launch a connection as you originally did?
> >
> > --
> > Aleksander
> > https://aleksander.es
> >
>
> Fine.
> I've rerun the --simple-connect method with Dans patch applied. MM log file
> attached.
Thanks! The problem is that we need 340ff7dc backported to MM 1.4 and
earlier. I've pushed that to the relevant branches, and attached here
for your testing. It should replace the previous patch.
Dan
From 340ff7dce3517b2b476a408572794e5206f43bac Mon Sep 17 00:00:00 2001
From: David McCullough <david.mccullo...@accelecon.com>
Date: Thu, 11 Sep 2014 12:00:33 +1000
Subject: [PATCH] broadband-modem-qmi: fix registration state when built with
--with-newest-qmi-commands
This patch fixes the registration reporting/checking when ModemManager is
built with --with-newest-qmi-commands. apply_cs and apply_ps were not
properly initialised and may never be true. Also fixes a CnP error for
mm_ps_registration_state.
Signed-off-by: David McCullough <david.mccullo...@accelecon.com>
---
src/mm-broadband-modem-qmi.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/src/mm-broadband-modem-qmi.c b/src/mm-broadband-modem-qmi.c
index 045b370..f4b6c55 100644
--- a/src/mm-broadband-modem-qmi.c
+++ b/src/mm-broadband-modem-qmi.c
@@ -4080,8 +4080,8 @@ process_common_info (QmiNasServiceStatus service_status,
gchar **mm_operator_id)
{
MMModem3gppRegistrationState tmp_registration_state;
- gboolean apply_cs;
- gboolean apply_ps;
+ gboolean apply_cs = TRUE;
+ gboolean apply_ps = TRUE;
if (service_status != QMI_NAS_SERVICE_STATUS_LIMITED &&
service_status != QMI_NAS_SERVICE_STATUS_AVAILABLE &&
@@ -4101,6 +4101,8 @@ process_common_info (QmiNasServiceStatus service_status,
apply_ps = FALSE;
else if (domain == QMI_NAS_NETWORK_SERVICE_DOMAIN_PS)
apply_cs = FALSE;
+ else if (domain == QMI_NAS_NETWORK_SERVICE_DOMAIN_CS_PS)
+ /* both apply */ ;
/* Check if we really are roaming or forbidden */
if (forbidden_valid && forbidden)
@@ -4122,7 +4124,7 @@ process_common_info (QmiNasServiceStatus service_status,
if (apply_cs)
*mm_cs_registration_state = tmp_registration_state;
if (apply_ps)
- *mm_cs_registration_state = tmp_registration_state;
+ *mm_ps_registration_state = tmp_registration_state;
if (network_id_valid) {
*mm_operator_id = g_malloc (7);
--
2.1.0
_______________________________________________
ModemManager-devel mailing list
ModemManager-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/modemmanager-devel
