On Mon, Nov 30, 2015 at 5:21 PM, Dan Williams <d...@redhat.com> wrote: > On Fri, 2015-11-27 at 14:51 +0100, Aleksander Morgado wrote: >> The new property is a dictionary which may include different >> parameters, >> depending on what is actually supported by the underlying modem. For >> now, >> just bytes RX/TX. >> >> Note that this object will expose the stats *as reported by the >> modem*. These >> values may differ from e.g. what is seen in the network interface >> stats. >> --- >> .../org.freedesktop.ModemManager1.Bearer.xml | 31 >> ++++++++++++++++++++++ >> 1 file changed, 31 insertions(+) >> >> diff --git a/introspection/org.freedesktop.ModemManager1.Bearer.xml >> b/introspection/org.freedesktop.ModemManager1.Bearer.xml >> index e1463a5..fe751cb 100644 >> --- a/introspection/org.freedesktop.ModemManager1.Bearer.xml >> +++ b/introspection/org.freedesktop.ModemManager1.Bearer.xml >> @@ -242,6 +242,37 @@ >> <property name="Ip6Config" type="a{sv}" access="read" /> >> >> <!-- >> + Stats: >> + >> + If the modem supports it, this property will show statistics >> of the >> + ongoing connection. >> + >> + When the connection is disconnected automatically or >> explicitly by the >> + user, the values in this property will show the last values >> cached. >> + The statistics are reset >> + >> + The following items may appear in the list of statistics: >> + <variablelist> >> + <varlistentry><term><literal>"bytes-rx"</literal></term> >> > > Any reason these are 'bytes-rx' instead of 'rx-bytes'? If you add > packets later that would be 'packets-rx', but I think the more > interesting information there is RX vs. TX, not packets vs. bytes... > both ifconfig and ethtool -S show stats with leading rx/tx.
No actual reason for those names; I'll change them to the ones you suggested. -- Aleksander https://aleksander.es _______________________________________________ ModemManager-devel mailing list ModemManager-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/modemmanager-devel