On Wed, Oct 12, 2016 at 5:29 PM, Dan Williams <d...@redhat.com> wrote: >> This is the 3rd update on the 'aleksander/ublox' branch, with this >> additional changes done after Dan's last review: >> >> * Recovered the original DENIED registration state logic. >> * Implemented a generic +CFUN parser and then included >> plugin-specific parsers for the ublox, linktop and mbm plugins, >> including unit tests. >> * Fixed the +UPINCNT patches which had some code squashed in the >> wrong commit. >> * Fixed RSRQ logic in +CESQ parser. >> * Updated +UBANDSEL parser to use g_strchomp() to get rid of >> trailing >> whitespaces, including CR and LF. >> >> Reviews of the implementation are more than welcome. >> https://cgit.freedesktop.org/ModemManager/ModemManager/log/?h=aleksan >> der/ublox > > Changes look good to me!
Merged now to git master :) thanks for reviewing! -- Aleksander https://aleksander.es _______________________________________________ ModemManager-devel mailing list ModemManager-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/modemmanager-devel