On Thu, Nov 24, 2016 at 6:04 PM, matthew stanger <stange...@gmail.com> wrote: > Uggg I am very sorry but that patch is not the right patch. It has none of > the fixes I worked on :(. Very sorry and terribly embarrassed. As soon as I > get back to my home computer I will mail out the correct one. I'd avoid > doing any work on this one for the next 24h.
Heh, that happens, don't worry. I actually found it strange that it didn't have some of the things we had talked about :) How about we work on the branch I pushed? Maybe you can review the changes and see if anything that you have in the latest patch could be included in the branch? I did some refactoring to make it look like the other plugins, and also reworked the helper method that does the SWWAN parsing, so maybe I left things out that I shouldn't have. -- Aleksander https://aleksander.es _______________________________________________ ModemManager-devel mailing list ModemManager-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/modemmanager-devel