On Mon, May 22, 2017 at 6:06 PM, Dan Williams <d...@redhat.com> wrote: >> The whitelist made all platform TTYs managed by the 'atmel_usart' >> kernel driver probed by ModemManager, which isn't something we want, >> as most of these aren't broadband modems. >> >> We leave the logic supporting the ID_MM_PLATFORM_DRIVER_PROBE udev >> tag >> as there may be a case where the user does need ModemManager to probe >> a given platform TTY. >> --- >> >> Hey Dan, >> >> From my understanding, I believe we don't want to automatically probe >> all platform ports exposed via the 'atmel_usart' driver. >> >> Looking at the attribute walk you sent me yesterday, I fail to see >> how the PCMCIA device would be tagged with >> ID_MM_PLATFORM_DRIVER_PROBE, so maybe this is something that was >> required in the past and now it's no longer needed? >> >> Let me know what you think. > > Yeah, probably the right thing to do for this driver. However, it > would break auto-probing for Thomas Bechtold if we take a time machine > back to 2012: > > https://mail.gnome.org/archives/networkmanager-list/2012-March/msg00167.html
Yeah, I don't think they should have had autoprobing for that. Being a platform port it should have had the PLATFORM udev tag added by the user, not by us. The company Thomas was working for at that time still uses MM 6.0 (with a couple of patches I did for them on top) so it wouldn't be a problem for them if we just remove it. -- Aleksander https://aleksander.es _______________________________________________ ModemManager-devel mailing list ModemManager-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/modemmanager-devel
