On Wed, Sep 27, 2017 at 5:10 PM, Colin Helliwell <colin.helliw...@ln-systems.com> wrote: > >> On 26 September 2017 at 14:23 Aleksander Morgado <aleksan...@aleksander.es> >> wrote: >> >> We need to specify explicitly that the return type is an array of >> >> guint8 elements. >> >> --- >> >> Hey Colin, >> >> Could you apply this patch and see if the generated introspection support >> allows you to use the API? It should work as g_bytes_get_data(), i.e.: >> https://lazka.github.io/pgi-docs/#GLib-2.0/classes/Bytes.html#GLib.Bytes.get_data >> >> --- >> libmm-glib/mm-sms.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/libmm-glib/mm-sms.c b/libmm-glib/mm-sms.c >> index a49deb88..0467b6c1 100644 >> --- a/libmm-glib/mm-sms.c >> +++ b/libmm-glib/mm-sms.c >> @@ -131,7 +131,7 @@ mm_sms_dup_text (MMSms *self) >> * >> >> * Gets the message data. >> * >> >> * * Returns: (transfer none): The message data, or %NULL if it >> doesn't contain any (e.g. contains text instead). >> >> * * Returns: (transfer none) (array length=data_len) (element-type >> guint8): The message data, or %NULL if it doesn't contain any (e.g. contains >> text instead). >> */ >> const guint8 * >> mm_sms_get_data (MMSms *self, >> @@ -158,7 +158,7 @@ mm_sms_get_data (MMSms *self, >> * >> >> * Gets the message data. >> * >> >> * * Returns: (transfer full): The message data, or %NULL if it >> doesn't contain any (e.g. contains text instead). The returned value should >> be freed with g_free(). >> >> * * Returns: (transfer full) (array length=data_len) (element-type >> guint8): The message data, or %NULL if it doesn't contain any (e.g. contains >> text instead). The returned value should be freed with g_free(). >> */ >> guint8 * >> mm_sms_dup_data (MMSms *self, >> -- >> 2.14.1 > > > LGTM - can it be pushed to Master?
Done -- Aleksander https://aleksander.es _______________________________________________ ModemManager-devel mailing list ModemManager-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/modemmanager-devel
