stas 2003/03/10 22:15:37
Modified: . STATUS Log: the issue with ${^TAINT} is a bug in blead-perl (perl_clone wasn't cloning PL_taint_warn). Patch posted to p5p, nothing should be done on behalf of mod_perl. Revision Changes Path 1.41 +1 -15 modperl-2.0/STATUS Index: STATUS =================================================================== RCS file: /home/cvs/modperl-2.0/STATUS,v retrieving revision 1.40 retrieving revision 1.41 diff -u -r1.40 -r1.41 --- STATUS 6 Mar 2003 04:08:02 -0000 1.40 +++ STATUS 11 Mar 2003 06:15:37 -0000 1.41 @@ -73,20 +73,6 @@ - why the loading doesn't happen - why the error doesn't happen (probably both connected) -* in blead-perl (where ${^TAINT} returns -1 for -t and 1 for -T, 0 - otherwise). in modperl/taint test under worker mpm ${^TAINT} returns - -1, when it should be 1. and the test fails - - in mg.c : - else if (strEQ(mg->mg_ptr, "\024AINT")) - sv_setiv(sv, PL_tainting - ? (PL_taint_warn || PL_unsafe ? -1 : 1) - : 0); - - need to check whether something different happens to PL_taint_warn - || PL_unsafe under worker mpm (it does the right thing with - prefork). - * 'SetHandler modperl' doesn't reset $|, so if anything turns it on anywhere, it's going to stay that way. Meaning excessive flushing probably causing a performance hit. I've tried to add the code to