stas 2003/12/09 17:47:16
Modified: xs/Apache/Filter Apache__Filter.h Log: add a potential problem concern note that needs to be investigated Revision Changes Path 1.34 +8 -0 modperl-2.0/xs/Apache/Filter/Apache__Filter.h Index: Apache__Filter.h =================================================================== RCS file: /home/cvs/modperl-2.0/xs/Apache/Filter/Apache__Filter.h,v retrieving revision 1.33 retrieving revision 1.34 diff -u -u -r1.33 -r1.34 --- Apache__Filter.h 10 Dec 2003 01:46:28 -0000 1.33 +++ Apache__Filter.h 10 Dec 2003 01:47:16 -0000 1.34 @@ -155,6 +155,14 @@ { modperl_filter_ctx_t *ctx = (modperl_filter_ctx_t *)(filter->ctx); + /* XXX: is it possible that the same filter, during a single + * request or connection cycle, will be invoked by different perl + * interpreters? if that happens we are in trouble, if we need to + * return an SV living in a different interpreter. may be there is + * a way to use one of the perl internal functions to clone an SV + * (and it can contain any references) + */ + if (data != Nullsv) { if (ctx->data) { if (SvOK(ctx->data) && SvREFCNT(ctx->data)) {