geoff 2003/12/23 07:56:01
Modified: src/modules/perl modperl_filter.c
Log:
note filter_init implementation issue
Revision Changes Path
1.80 +6 -1 modperl-2.0/src/modules/perl/modperl_filter.c
Index: modperl_filter.c
===================================================================
RCS file: /home/cvs/modperl-2.0/src/modules/perl/modperl_filter.c,v
retrieving revision 1.79
retrieving revision 1.80
diff -u -r1.79 -r1.80
--- modperl_filter.c 23 Dec 2003 03:02:34 -0000 1.79
+++ modperl_filter.c 23 Dec 2003 15:56:01 -0000 1.80
@@ -405,7 +405,12 @@
modperl_filter_mg_set(aTHX_ AvARRAY(args)[0], filter);
- /* XXX filters are VOID handlers. should we ignore the status? */
+ /* XXX filter_init return status is propagated back to Apache over
+ * in C land, making it possible to use filter_init to return, say,
+ * BAD_REQUEST. this implementation, however, ignores the return status
+ * even though we're trapping it here - modperl_filter_add_request sees
+ * the error and propagates it, but modperl_output_filter_add_request
+ * is void so the error is lost */
if ((status = modperl_callback(aTHX_ handler, p, r, s, args)) != OK) {
status = modperl_errsv(aTHX_ status, r, s);
}
