stas 2004/06/29 18:50:03
Modified: t/protocol/TestProtocol echo_bbs.pm echo_bbs2.pm echo_filter.pm Log: fix a bug in protocol handler tests where the while(1) loop wasn't getting broken, needed to check for APR::EOF to break Revision Changes Path 1.3 +1 -0 modperl-2.0/t/protocol/TestProtocol/echo_bbs.pm Index: echo_bbs.pm =================================================================== RCS file: /home/cvs/modperl-2.0/t/protocol/TestProtocol/echo_bbs.pm,v retrieving revision 1.2 retrieving revision 1.3 diff -u -u -r1.2 -r1.3 --- echo_bbs.pm 9 Jun 2004 14:46:22 -0000 1.2 +++ echo_bbs.pm 30 Jun 2004 01:50:03 -0000 1.3 @@ -36,6 +36,7 @@ } last if $bb_in->is_empty; + last if $rc == APR::EOF; while (!$bb_in->is_empty) { my $bucket = $bb_in->first; 1.3 +1 -0 modperl-2.0/t/protocol/TestProtocol/echo_bbs2.pm Index: echo_bbs2.pm =================================================================== RCS file: /home/cvs/modperl-2.0/t/protocol/TestProtocol/echo_bbs2.pm,v retrieving revision 1.2 retrieving revision 1.3 diff -u -u -r1.2 -r1.3 --- echo_bbs2.pm 9 Jun 2004 14:46:22 -0000 1.2 +++ echo_bbs2.pm 30 Jun 2004 01:50:03 -0000 1.3 @@ -35,6 +35,7 @@ warn __PACKAGE__ . ": get_brigade: $error\n"; last; } + last if $rc == APR::EOF; next unless $bb_in->flatten(my $data); $bb->cleanup; 1.15 +2 -0 modperl-2.0/t/protocol/TestProtocol/echo_filter.pm Index: echo_filter.pm =================================================================== RCS file: /home/cvs/modperl-2.0/t/protocol/TestProtocol/echo_filter.pm,v retrieving revision 1.14 retrieving revision 1.15 diff -u -u -r1.14 -r1.15 --- echo_filter.pm 3 Jun 2004 08:20:13 -0000 1.14 +++ echo_filter.pm 30 Jun 2004 01:50:03 -0000 1.15 @@ -53,6 +53,8 @@ # $bb->insert_tail($b); # $c->output_filters->pass_brigade($bb); $c->output_filters->fflush($bb); + + last if $rc == APR::EOF; } $bb->destroy;