Author: stas Date: Fri Dec 24 15:36:32 2004 New Revision: 123306 URL: http://svn.apache.org/viewcvs?view=rev&rev=123306 Log: - just figured that all XS wrappers returning strings already copy the string, so it doesn't matter if the pool goes out of scope or not - consider to avoid copying though
Modified: perl/modperl/trunk/todo/features_optimization perl/modperl/trunk/todo/release Modified: perl/modperl/trunk/todo/features_optimization Url: http://svn.apache.org/viewcvs/perl/modperl/trunk/todo/features_optimization?view=diff&rev=123306&p1=perl/modperl/trunk/todo/features_optimization&r1=123305&p2=perl/modperl/trunk/todo/features_optimization&r2=123306 ============================================================================== --- perl/modperl/trunk/todo/features_optimization (original) +++ perl/modperl/trunk/todo/features_optimization Fri Dec 24 15:36:32 2004 @@ -2,6 +2,23 @@ # working features but requiring optimization # ############################################### +* all autogenerated xs methods that return char * are now using + sv_setpv() which always copies the string. See if we somehow can + avoid the copy. If we do so, we need to be careful with method which + take a pool argument, such as: + Apache::ServerUtil + - mpxs_Apache__ServerUtil_server_root_relative + Apache::URI: + - ap_construct_server + - ap_construct_url + APR::URI + - mpxs_apr_uri_parse + Apache::Util + - ap_ht_time + - escape_path + for which we need to attach the pool object used to create those + strings as a magic. + * optimize modperl_callback_current_callback_(set|get) to use numerical equivalents of the phase names, instead of doing expensive memory allocs and string comparison operations. And only give the Modified: perl/modperl/trunk/todo/release Url: http://svn.apache.org/viewcvs/perl/modperl/trunk/todo/release?view=diff&rev=123306&p1=perl/modperl/trunk/todo/release&r1=123305&p2=perl/modperl/trunk/todo/release&r2=123306 ============================================================================== --- perl/modperl/trunk/todo/release (original) +++ perl/modperl/trunk/todo/release Fri Dec 24 15:36:32 2004 @@ -68,35 +68,6 @@ Apache::RequestUtil: ? mpxs_Apache__RequestRec_new (having problems): Apache__RequestUtil.patch - *** returning strings *** - - Apache::ServerUtil - - mpxs_Apache__ServerUtil_server_root_relative (once this is - supported, we no longer need to double copy the string) - - Apache::URI: - - ap_construct_server - - ap_construct_url - APR::URI - mpxs_apr_uri_parse - - Apache::Util - - ap_ht_time - - escape_path - - ========================== - === Apache::SubRequest === - ========================== - no method uses the object in a way related to the issue in hand - - ================= - === APR::UUID === - ================= - no method uses the object in a way related to the issue in hand - - ======================== - === APR::ThreadMutex === - ======================== - no method uses the object in a way related to the issue in hand
