Modified: perl/modperl/trunk/t/response/TestModperl/pnotes2.pm URL: http://svn.apache.org/viewvc/perl/modperl/trunk/t/response/TestModperl/pnotes2.pm?rev=607697&r1=607696&r2=607697&view=diff ============================================================================== --- perl/modperl/trunk/t/response/TestModperl/pnotes2.pm (original) +++ perl/modperl/trunk/t/response/TestModperl/pnotes2.pm Mon Dec 31 00:05:11 2007 @@ -41,37 +41,37 @@ if(!defined $r->args) { } elsif($r->args == 1) { - $r->pnotes(x1 => TestModerl::pnotes2::x->new(\&line)); + $r->pnotes(x1 => TestModerl::pnotes2::x->new(\&line)); } elsif($r->args == 2) { - $r->pnotes->{x1} = TestModerl::pnotes2::x->new(\&line); + $r->pnotes->{x1} = TestModerl::pnotes2::x->new(\&line); } elsif($r->args == 3) { - $r->pnotes(x1 => TestModerl::pnotes2::x->new(\&line)); - $r->pnotes(x2 => 2); + $r->pnotes(x1 => TestModerl::pnotes2::x->new(\&line)); + $r->pnotes(x2 => 2); } elsif($r->args == 4) { - $r->pnotes->{x1} = TestModerl::pnotes2::x->new(\&line); - $r->pnotes->{x2} = 2; + $r->pnotes->{x1} = TestModerl::pnotes2::x->new(\&line); + $r->pnotes->{x2} = 2; } elsif($r->args == 5) { - $r->pnotes(x1 => TestModerl::pnotes2::x->new(\&line)); - $r->pnotes->{x2} = 2; + $r->pnotes(x1 => TestModerl::pnotes2::x->new(\&line)); + $r->pnotes->{x2} = 2; } elsif($r->args == 6) { - $r->pnotes->{x1} = TestModerl::pnotes2::x->new(\&line); - $r->pnotes(x2 => 2); + $r->pnotes->{x1} = TestModerl::pnotes2::x->new(\&line); + $r->pnotes(x2 => 2); } elsif($r->args == 7) { - $r->connection->pnotes(x1 => TestModerl::pnotes2::x->new(\&line)); + $r->connection->pnotes(x1 => TestModerl::pnotes2::x->new(\&line)); } elsif($r->args == 8) { - $r->connection->pnotes->{x1} = TestModerl::pnotes2::x->new(\&line); + $r->connection->pnotes->{x1} = TestModerl::pnotes2::x->new(\&line); } elsif($r->args == 9) { - $r->connection->pnotes(x1 => TestModerl::pnotes2::x->new(\&line)); - $r->connection->pnotes(x2 => 2); + $r->connection->pnotes(x1 => TestModerl::pnotes2::x->new(\&line)); + $r->connection->pnotes(x2 => 2); } elsif($r->args == 10) { - $r->connection->pnotes->{x1} = TestModerl::pnotes2::x->new(\&line); - $r->connection->pnotes->{x2} = 2; + $r->connection->pnotes->{x1} = TestModerl::pnotes2::x->new(\&line); + $r->connection->pnotes->{x2} = 2; } elsif($r->args == 11) { - $r->connection->pnotes(x1 => TestModerl::pnotes2::x->new(\&line)); - $r->connection->pnotes->{x2} = 2; + $r->connection->pnotes(x1 => TestModerl::pnotes2::x->new(\&line)); + $r->connection->pnotes->{x2} = 2; } elsif($r->args == 12) { - $r->connection->pnotes->{x1} = TestModerl::pnotes2::x->new(\&line); - $r->connection->pnotes(x2 => 2); + $r->connection->pnotes->{x1} = TestModerl::pnotes2::x->new(\&line); + $r->connection->pnotes(x2 => 2); } $r->content_type('text/plain');
Modified: perl/modperl/trunk/t/response/TestModperl/printf.pm URL: http://svn.apache.org/viewvc/perl/modperl/trunk/t/response/TestModperl/printf.pm?rev=607697&r1=607696&r2=607697&view=diff ============================================================================== --- perl/modperl/trunk/t/response/TestModperl/printf.pm (original) +++ perl/modperl/trunk/t/response/TestModperl/printf.pm Mon Dec 31 00:05:11 2007 @@ -31,7 +31,7 @@ # ok 4 (gets input from the fixup handler via notes) { my $note = $r->notes->get("fixup") || ''; - my $ok = $note =~ + my $ok = $note =~ /\$r->printf can't be called before the response phase/; $r->print("not ") unless $ok; $r->print("ok 4\n"); Modified: perl/modperl/trunk/t/response/TestModperl/request_rec_perlio_api.pm URL: http://svn.apache.org/viewvc/perl/modperl/trunk/t/response/TestModperl/request_rec_perlio_api.pm?rev=607697&r1=607696&r2=607697&view=diff ============================================================================== --- perl/modperl/trunk/t/response/TestModperl/request_rec_perlio_api.pm (original) +++ perl/modperl/trunk/t/response/TestModperl/request_rec_perlio_api.pm Mon Dec 31 00:05:11 2007 @@ -93,7 +93,7 @@ # now close it completely and restore it, without using any dupped # filehandle close STDOUT; - open STDOUT, ">:Apache2", $r + open STDOUT, ">:Apache2", $r or die "can't open STDOUT via :Apache2 layer : $!"; print "next you reincarnate..."; Modified: perl/modperl/trunk/t/response/TestModperl/setupenv.pm URL: http://svn.apache.org/viewvc/perl/modperl/trunk/t/response/TestModperl/setupenv.pm?rev=607697&r1=607696&r2=607697&view=diff ============================================================================== --- perl/modperl/trunk/t/response/TestModperl/setupenv.pm (original) +++ perl/modperl/trunk/t/response/TestModperl/setupenv.pm Mon Dec 31 00:05:11 2007 @@ -321,7 +321,7 @@ PerlSetEnv DIR_PERLSETENV psvoid </Location> - # equivalent to modperl handler with $r->subprocess_env() - + # equivalent to modperl handler with $r->subprocess_env() - # CGI variables are there, but not subprocess_env entries # that are populated after the void call <Location /TestModperl__setupenv_psnosetupvoid> Modified: perl/modperl/trunk/t/response/TestModperl/subenv.pm URL: http://svn.apache.org/viewvc/perl/modperl/trunk/t/response/TestModperl/subenv.pm?rev=607697&r1=607696&r2=607697&view=diff ============================================================================== --- perl/modperl/trunk/t/response/TestModperl/subenv.pm (original) +++ perl/modperl/trunk/t/response/TestModperl/subenv.pm Mon Dec 31 00:05:11 2007 @@ -32,7 +32,7 @@ ok ! $ENV{$key}; # %ENV not populated yet } - # subprocess_env in void context with no arguments + # subprocess_env in void context with no arguments # populates the same as +SetEnv { my $env = $r->subprocess_env; Modified: perl/modperl/trunk/t/response/TestPerl/hash_attack.pm URL: http://svn.apache.org/viewvc/perl/modperl/trunk/t/response/TestPerl/hash_attack.pm?rev=607697&r1=607696&r2=607697&view=diff ============================================================================== --- perl/modperl/trunk/t/response/TestPerl/hash_attack.pm (original) +++ perl/modperl/trunk/t/response/TestPerl/hash_attack.pm Mon Dec 31 00:05:11 2007 @@ -92,7 +92,7 @@ $stash->{$s}++; debug sprintf "%2d: %5s, %10s, %s", $c, $s, $h, scalar(%$stash); push @keys, $s; - debug "The hash collision attack has been successful" + debug "The hash collision attack has been successful" if Internals::HvREHASH(%$stash); } continue { $s++; Modified: perl/modperl/trunk/t/response/TestPerl/ithreads.pm URL: http://svn.apache.org/viewvc/perl/modperl/trunk/t/response/TestPerl/ithreads.pm?rev=607697&r1=607696&r2=607697&view=diff ============================================================================== --- perl/modperl/trunk/t/response/TestPerl/ithreads.pm (original) +++ perl/modperl/trunk/t/response/TestPerl/ithreads.pm Mon Dec 31 00:05:11 2007 @@ -62,9 +62,9 @@ $counter_priv += $counter_priv for 1..10; { - lock $counter_shar; - $counter_shar += $counter_shar for 1..10; - } + lock $counter_shar; + $counter_shar += $counter_shar for 1..10; + } $thr->join; ok t_cmp($counter_shar, 2**20, "shared counter"); Modified: perl/modperl/trunk/t/response/TestPerl/ithreads_eval.pm URL: http://svn.apache.org/viewvc/perl/modperl/trunk/t/response/TestPerl/ithreads_eval.pm?rev=607697&r1=607696&r2=607697&view=diff ============================================================================== --- perl/modperl/trunk/t/response/TestPerl/ithreads_eval.pm (original) +++ perl/modperl/trunk/t/response/TestPerl/ithreads_eval.pm Mon Dec 31 00:05:11 2007 @@ -3,7 +3,7 @@ # reproducing a bug in perl ithreads: [perl #34341] # https://rt.perl.org/rt3/Ticket/Display.html?id=34341 # -# $thr->join triggers the following leak: +# $thr->join triggers the following leak: # - due to to local $0, (its second MAGIC's MG_OBJ, # you can see it in the output of Dump $0). This leak was first # spotted in the RegistryCooker.pm which localizes $0
