Stas Bekman wrote:
Anybody has an idea why mp1 build does:

PERL5LIB = "PERL5LIB=/path/to/mod_perl-1.29/lib",

(see the top-level Makefile).

I can't see how is it going to work:

Answering my own question, and the answer is trivial, this is just how we pass PERL5LIB env var to the shell commands via Makefile, e.g.:


(cd $(APACHE_ROOT) && $(PERL5LIB) $(MAKE))

becomes:

(cd ../apache && PERL5LIB=/path/to/mod_perl-1.29/lib make)

however, for some reason .pm files during the modperl build see $ENV{PERL5LIB} as "PERL5LIB=/path:/another/path" instead of "/path:/another/path" essentially rendering this env var useless. I'm not sure why, may be MakeMaker kicks in somewhere. I came up with a simple solution s/PERL5LIB/PERL5LIB_ENV/, anything that's not PERL5LIB.

Index: Makefile.PL
===================================================================
RCS file: /home/cvs/modperl/Makefile.PL,v
retrieving revision 1.218
diff -u -r1.218 Makefile.PL
--- Makefile.PL 9 Oct 2003 05:10:29 -0000       1.218
+++ Makefile.PL 13 Nov 2003 06:45:37 -0000
@@ -1291,7 +1291,7 @@
        HTTPD => $TARGET,
        PORT => $PORT,
        PWD => $PWD,
-        PERL5LIB => "PERL5LIB=$ENV{PERL5LIB}",
+        PERL5LIB_ENV => "PERL5LIB_ENV=$ENV{PERL5LIB}",
        SHRPENV => $Config{shrpenv},
        CVSROOT => 'cvs.apache.org:/home/cvs',
     },
@@ -1419,16 +1419,16 @@
        (cd ./apaci && $(MAKE) distclean)

 apxs_libperl:
-       (cd ./apaci && $(PERL5LIB) $(MAKE))
+       (cd ./apaci && $(PERL5LIB_ENV) $(MAKE))

 apxs_install: apxs_libperl
        (cd ./apaci && $(MAKE) install;)

 apache_httpd: $(APACHE_SRC)/Makefile.tmpl
-       (cd $(APACHE_SRC) && $(PERL5LIB) $(SHRPENV) $(MAKE) CC="$(CC)";)
+       (cd $(APACHE_SRC) && $(PERL5LIB_ENV) $(SHRPENV) $(MAKE) CC="$(CC)";)

 apaci_httpd:
-       (cd $(APACHE_ROOT) && $(PERL5LIB) $(MAKE))
+       (cd $(APACHE_ROOT) && $(PERL5LIB_ENV) $(MAKE))

 apaci_install:
        (cd $(APACHE_ROOT) && $(MAKE) install)

Unless somebody objects to that change I'm going to commit it soonish.

__________________________________________________________________
Stas Bekman            JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/     mod_perl Guide ---> http://perl.apache.org
mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com


-- Reporting bugs: http://perl.apache.org/bugs/ Mail list info: http://perl.apache.org/maillist/modperl.html



Reply via email to