Randy Kobes wrote: >On Thu, 20 May 2004, Geoffrey Young wrote: > > > >>a release candidate for mod_perl 1.99_14 is now available for testing. >> >> >Hi Geoff, > On Win32 (perl-5.8.3, ActivePerl 809 compatible), with >Apache/2.0.49, there's a problem (often) in starting the >tests, due to ThreadsPerChild being set too low (Steve, >do you still find this?). This diff > >=================================================================== >Index: Apache-Test/lib/Apache/TestConfig.pm >=================================================================== >RCS file: /home/cvs/httpd-test/perl-framework/Apache-Test/lib/Apache/TestConfig.pm,v >retrieving revision 1.222 >diff -u -r1.222 TestConfig.pm >--- Apache-Test/lib/Apache/TestConfig.pm 16 Apr 2004 20:29:23 -0000 1.222 >+++ Apache-Test/lib/Apache/TestConfig.pm 20 May 2004 06:11:47 -0000 >@@ -1878,7 +1878,7 @@ > </IfDefine> > > <IfModule mpm_winnt.c> >- ThreadsPerChild 20 >+ ThreadsPerChild 25 > MaxRequestsPerChild 0 > </IfModule> > >=========================================================================== >allows the tests to start for me. > Not this one again! We've been here several times before -- see http://marc.theaimsgroup.com/?l=apache-modperl-dev&m=108296767420298&w=2.
The patch above is fine if you think it is worth applying after all (given that Apache 2.0.50 isn't out yet). > >However, I then find some failures due to a problem we >encountered before (occasionally) - on Win32, when comparing >two file names, sometimes the DOS short path name is >compared to the long path name. This doesn't arise for me >all the time, as it seems to depend on where it's unpacked. >In any case, a solution is to use t_catfile of >Apache::TestUtil, rather than catfile of File::Spec, in a >few places, as well as introduce an analagous t_canonpath - >these two functions do what the File::Spec counterparts do, >but for Win32 they convert the filename to a long path name, >if relevant. > I don't remember seeing that with mp2, but I know I had it once with apreq2. Your patch seems fine anyway, apart from one problem: I have apache\conftree.t failing tests 6-7. Here's the output under -verbose: # expected: C:\apache2\sources\mod_perl-1.99_14-dev\t\htdocs # received: "C:\apache2\sources\mod_perl-1.99_14-dev\t\htdocs" not ok 6 # expected: C:\apache2\sources\mod_perl-1.99_14-dev\t\htdocs # received: "C:\apache2\sources\mod_perl-1.99_14-dev\t\htdocs" not ok 7 The original test did have the double-quotes in the "expected" string, so I'll leave you to figure out an obvious fix. The bad news is that on my setup (Apache 2.0.49, Perl 5.8.4) I haven't yet seen the mp2 test suite run properly yet. (The same Apache/Perl combination worked fine with 1.99_13.) When running "nmake test" I usually get t\compat\send_fd.t and t\directive\setupenv.t failing like this: t\compat\send_fd........................response had protocol HTTP/0.9 (headers not sent?) at t\compat\send_fd.t line 15 t\compat\send_fd........................dubious Test returned status 9 (wstat 2304, 0x900) DIED. FAILED tests 1-3 Failed 3/3 tests, 0.00% okay t\directive\setupenv....................response had protocol HTTP/0.9 (headers not sent?) at t\directive\setupenv.t line 12 t\directive\setupenv....................dubious Test returned status 9 (wstat 2304, 0x900) DIED. FAILED tests 1-3 Failed 3/3 tests, 0.00% okay but they both pass OK when I run them manually via t/TEST. I then have "nmake test" sometimes failing completely on t\directive\pod (Apache.exe throws up a popup Application Error and crashes). Other times that test runs OK, but then it hangs on t\error\runtime.t. If I kill that test then rest of the tests complete without error. There's nothing useful in the error_log, and I'm shit out of time to look further into it right now. I'll try to find some time whenever I can, but in the meantime, are you able to try with 5.8.4, Randy? - Steve ------------------------------------------------ Radan Computational Ltd. The information contained in this message and any files transmitted with it are confidential and intended for the addressee(s) only. If you have received this message in error or there are any problems, please notify the sender immediately. The unauthorized use, disclosure, copying or alteration of this message is strictly forbidden. Note that any views or opinions presented in this email are solely those of the author and do not necessarily represent those of Radan Computational Ltd. The recipient(s) of this message should check it and any attached files for viruses: Radan Computational will accept no liability for any damage caused by any virus transmitted by this email. -- Report problems: http://perl.apache.org/bugs/ Mail list info: http://perl.apache.org/maillist/modperl.html List etiquette: http://perl.apache.org/maillist/email-etiquette.html